Skip to content

tests/nordic_softdevice: cleanup test script and fix test#12465

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/tests/nordic_softdevice
Oct 16, 2019
Merged

tests/nordic_softdevice: cleanup test script and fix test#12465
miri64 merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/tests/nordic_softdevice

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Oct 16, 2019

Contribution description

This is an attempt to fix #12214 and it does 2 things:

  • cleanup of the test script
  • add a 1s delay after the shell is effectively ready (> displayed) before requesting the interface with the ifconfig command.

After this fix, the test is working reliably locally.

For me this is a bit minor, so I don't really think it needs a backport but maybe other will disagree.

Testing procedure

Use the following script (from the RIOT base directory):

#! /bin/bash -xe

make --no-print-directory -C tests/nordic_softdevice/

for i in {0..10}; do
    make --no-print-directory -C tests/nordic_softdevice/ flash-only test
done

On master, it fails most of the time. With this PR it works all the time.

Issues/PRs references

fixes #12214

Adding a 1s delay before sending ifconfig makes this test works reliably because it gives the softdevice enough time to get in a ready state.
@aabadie aabadie added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Oct 16, 2019
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 16, 2019
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one unrelated error on Murdock, so I am inclined to ACK this.

@miri64 miri64 merged commit eebf370 into RIOT-OS:master Oct 16, 2019
@aabadie aabadie deleted the pr/tests/nordic_softdevice branch October 16, 2019 11:45
@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Oct 16, 2019

Thank you @miri64!

@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests/nordic_softdevice fails randomly when doing flash test

3 participants