CDCACM: Add interface association descriptor before CDC ACM control interface descriptor#12430
Merged
dylad merged 1 commit intoRIOT-OS:masterfrom Oct 20, 2019
Merged
Conversation
bergzand
added
Type: bug
bergzand
changed the title
bergzand
force-pushed
the
wip/cdcacm/assoc
branch
from
df4c994 to
80f9788
Compare
Member
Author
|
rebased, no longer waiting for other PR's |
dylad
added
Reviewed: 1-fundamentals
dylad
approved these changes
Oct 20, 2019
Member
dylad
left a comment
dylad
left a comment
There was a problem hiding this comment.
Tested this PR on Linux and W10. cdc/acm on Linux works as expected and it also works out of the box with W10. Enumeration / serial port works perfectly !
dylad
added
the
CI: ready for build
Member
|
Here we go |
Member
Author
|
This broke support for me on Linux due to a claimed header length mismatch. Will open a PR to fix this asap. Not sure how this slipped through on bot my test and @dylad's test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This adds an interface association descriptor to the USBUS CDC ACM code. This should enable the Windows operating system (at least version 10) to correctly enumerate, detect and use the CDC ACM functionality in RIOT.
Background
Currently RIOT describes itself as a composite device to host computers. When this is used, WIndows uses interface association descriptors to detect logical interface collections on the device1.
Testing procedure
Flash the
tests/usbus_cdc_acm_stdiotest on a board, Windows should correctly detect the COM device and allow usage of said COM device.More extensive test (as already done by @chrysn) would be to add the CDC ECM in different configurations and test that Windows does not enable the CDC ECM functionality, but does offer the COM functionality of the device.
(Linux and MacOS should still work just fine)
Issues/PRs references
Depends on #12429