tests/gnrc_tcp: provide regression tests for fixed issues by miri64 · Pull Request #12369 · RIOT-OS/RIOT

miri64 · 2019-10-03T17:47:07Z

Contribution description

This provides regression tests for some issues that were found in the past. The respective issues are quoted in the comments. I actually already found a regression when implementing these (see #12368).

Testing procedure

BOARD="<pick one>" make -C tests/gnrc_tcp flash
sudo make -C tests/gnrc_tcp test

Issues/PRs references

Require #12368 to work.

miri64 · 2019-10-04T07:43:27Z

@nmeum @brummer-simon please have a look.

brummer-simon

Thanks for providing additional tests to the latest issues.

By looking at the given flake8 config line length up to 119 characters are allowed. Would you please look over the code reformat function calls that are split over multiple lines. It is just easier to read and RIOT deviates from PEP8 in terms of max line length anyway. Aside from that, good job.

tests/gnrc_tcp/tests/05-garbage-pkts.py

brummer-simon

ACK by me.

Aside from code review I tested the PR on 'native'.

EDIT: I'll revert my ACK see next comment.

brummer-simon

I found something small while executing the test on "nucleo-f401re".

tests/gnrc_tcp/tests/05-garbage-pkts.py

brummer-simon · 2019-10-05T11:36:47Z

ACK from my side. Tested here on nucleo-f401re

miri64 · 2019-10-05T13:14:36Z

Rebased to current master to include #12368.

miri64 · 2019-10-05T13:15:27Z

@RIOT-OS/maintainers this also needs a proxy-ACK.

aabadie

Proxy-ACK (also had a look and found no major issues codewise).

You can squash.

miri64 · 2019-10-05T17:26:53Z

@aabadie, so I will squash. Can you maybe also test on samr21-xpro, just to be sure? I didn't have one at hand when working with the tests.

miri64 · 2019-10-06T15:35:17Z

Provided fix for a typo

fjmolinas · 2019-10-06T17:28:57Z

Just following the README and testing on samr21-xpro I have a timeout on gnrc_tcp_open_active:

EDIT: the following output is with echo=true

sudo -E BOARD=samr21-xpro make -C tests/gnrc_tcp test

make: Entering directory '/home/francisco/Workspace/RIOT/tests/gnrc_tcp'
make[1]: Nothing to be done for 'all'.
buffer_init
buffer_get_max_size
make[2]: Nothing to be done for 'all'.
sudo /home/francisco/Workspace/RIOT/dist/tools/ethos/ethos tap0 /dev/ttyACM0 115200
----> ethos: sending hello.
----> ethos: activating serial pass through.
----> ethos: hello reply received
----> ethos: hello received
main(): This is RIOT! (Version: 2019.10-devel-1314-gd9047a-pr-12369)
RIOT GNRC_TCP test application
> buffer_init: argc=1, argv[0] = buffer_init
> buffer_get_max_size: argc=1, argv[0] = buffer_get_max_size
buffer_get_max_size: returns 2048
ifconfig
> Iface  5  HWaddr: 00:31:8B:E0:2D:3F 
gnrc_tcp_tcb_init
gnrc_tcp_open_active AF_INET6 fe80::84a8:e8ff:fe16:6c9b%5 60720 0
          L2-PDU:1500 MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::231:8bff:fee0:2d3f  scope: local  TNT[1]
          inet6 group: ff02::1
          inet6 group: ff02::1:ffe0:2d3f
          
> gnrc_tcp_tcb_init: argc=1, argv[0] = gnrc_tcp_tcb_init
> gnrc_tcp_open_active: argc=5, argv[0] = gnrc_tcp_open_active, argv[1] = AF_INET6, argv[2] = fe80::84a8:e8ff:fe16:6c9b%5, argv[3] = 60720, argv[4] = 0
gnrc_tcp_open_active: returns -ETIMEOUT
> Timeout in expect script at "child.expect_exact('gnrc_tcp_open_active: returns 0')" (tests/gnrc_tcp/tests/03-send_data.py:44)
  File "/home/francisco/Workspace/RIOT/dist/pythonlibs/testrunner/__init__.py", line 29, in run
    testfunc(child)
  File "/home/francisco/Workspace/RIOT/tests/gnrc_tcp/tests/03-send_data.py", line 44, in testfunc
    child.expect_exact('gnrc_tcp_open_active: returns 0')
  File "/usr/lib/python3/dist-packages/pexpect/spawnbase.py", line 384, in expect_exact
    return exp.expect_loop(timeout)
  File "/usr/lib/python3/dist-packages/pexpect/expect.py", line 104, in expect_loop
    return self.timeout(e)
  File "/usr/lib/python3/dist-packages/pexpect/expect.py", line 68, in timeout
    raise TIMEOUT(msg)

miri64 · 2019-10-06T17:39:30Z

Just following the README and testing on samr21-xpro I have a timeout on gnrc_tcp_open_active:
sudo -E BOARD=samr21-xpro make -C tests/gnrc_tcp test

This test is not introduced here (the tests here only use gnrc_tcp_open_passive, but I had this occassionally when testing #11930. I hoped the increased timeout would help. In any way: this is unrelated to this PR.

miri64 · 2019-10-06T17:40:19Z

Why is there output in your script btw Oo?

fjmolinas · 2019-10-06T19:41:59Z

Why is there output in your script btw Oo?

I set echo=true to see what was timing ou.

fjmolinas · 2019-10-06T19:45:34Z

This test is not introduced here (the tests here only use gnrc_tcp_open_passive, but I had this occassionally when testing #11930. I hoped the increased timeout would help. In any way: this is unrelated to this PR.

In that case If I limit the test to tests/gnrc_tcp/tests/05-garbage-pkts.py:

sudo -E BOARD=samr21-xpro make -C tests/gnrc_tcp test
make: Entering directory '/home/francisco/Workspace/RIOT/tests/gnrc_tcp'
make[1]: Nothing to be done for 'all'.
- test_short_payload SUCCESS

- test_short_header SUCCESS

- test_send_ack_instead_of_syn SUCCESS

- test_option_parsing_term SUCCESS

05-garbage-pkts.py: success

make: Leaving directory '/home/francisco/Workspace/RIOT/tests/gnrc_tcp'

miri64 · 2019-10-07T04:14:43Z

👍 I'll see if I can reproduce the other test.

miri64 · 2019-10-07T17:12:29Z

(yes I am, but for different cases than @fjmolinas was able to and only in some cases... @brummer-simon I think there is still some stabilization work required to be done to the tests commands...)

miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking Area: tests Area: tests and testing framework labels Oct 3, 2019

miri64 requested a review from brummer-simon October 3, 2019 17:47

brummer-simon suggested changes Oct 5, 2019

View reviewed changes

brummer-simon mentioned this pull request Oct 5, 2019

gnrc_tcp: return immediatly on gnrc_tcp_recv if a connection is closing #12367

Merged

brummer-simon reviewed Oct 5, 2019

View reviewed changes

brummer-simon suggested changes Oct 5, 2019

View reviewed changes

tests/gnrc_tcp/tests/05-garbage-pkts.py Outdated Show resolved Hide resolved

brummer-simon approved these changes Oct 5, 2019

View reviewed changes

miri64 added 2 commits October 5, 2019 15:12

tests/gnrc_tcp: fix sudo error message

00f7e52

tests/gnrc_tcp: prepare shared_func for scapy

e22084c

miri64 force-pushed the tests/enh/gnrc_tcp branch from 1780e36 to ef52600 Compare October 5, 2019 13:12

miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 5, 2019

aabadie approved these changes Oct 5, 2019

View reviewed changes

miri64 force-pushed the tests/enh/gnrc_tcp branch from ef52600 to e14765d Compare October 5, 2019 17:28

tests/gnrc_tcp: provide regression tests for fixed issues

c3a85bb

miri64 force-pushed the tests/enh/gnrc_tcp branch from e14765d to c3a85bb Compare October 6, 2019 15:35

miri64 merged commit cac8a50 into RIOT-OS:master Oct 7, 2019

miri64 deleted the tests/enh/gnrc_tcp branch October 7, 2019 04:14

kb2ma added this to the Release 2019.10 milestone Oct 28, 2019

nmeum mentioned this pull request Jan 17, 2020

Add AFL-based fuzzing setup for network modules #13157

Merged

Conversation

miri64 commented Oct 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution description

Testing procedure

Issues/PRs references

Uh oh!

miri64 commented Oct 4, 2019

Uh oh!

brummer-simon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brummer-simon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brummer-simon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

brummer-simon commented Oct 5, 2019

Uh oh!

miri64 commented Oct 5, 2019

Uh oh!

miri64 commented Oct 5, 2019

Uh oh!

aabadie left a comment

Choose a reason for hiding this comment

Uh oh!

miri64 commented Oct 5, 2019

Uh oh!

miri64 commented Oct 6, 2019

Uh oh!

fjmolinas commented Oct 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miri64 commented Oct 6, 2019

Uh oh!

miri64 commented Oct 6, 2019

Uh oh!

fjmolinas commented Oct 6, 2019

Uh oh!

fjmolinas commented Oct 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miri64 commented Oct 7, 2019

Uh oh!

miri64 commented Oct 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

miri64 commented Oct 3, 2019 •

edited

Loading

brummer-simon left a comment •

edited

Loading

brummer-simon left a comment •

edited

Loading

fjmolinas commented Oct 6, 2019 •

edited

Loading

fjmolinas commented Oct 6, 2019 •

edited

Loading