Skip to content

gnrc_sixlowpan_frag_rb: add new functions for SFR#12349

Merged
miri64 merged 4 commits intoRIOT-OS:masterfrom
miri64:gnrc_sixlowpan_frag_rb/enh/new-functions
Oct 19, 2019
Merged

gnrc_sixlowpan_frag_rb: add new functions for SFR#12349
miri64 merged 4 commits intoRIOT-OS:masterfrom
miri64:gnrc_sixlowpan_frag_rb/enh/new-functions

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Oct 1, 2019 •
edited
Loading

Contribution description

This extends the 6LoWPAN reassembly buffer by two functions specifically for Selective Fragment Recovery:

  • gnrc_sixlowpan_frag_rb_exists() checks if an entry with given parameters exist.
  • gnrc_sixlowpan_frag_rb_rm_by_datagram() removes an entry by given parameters.o

In both cases datagram_size is not a search parameter as this information only exists in the first fragment and thus can't be determined for subsequent fragments without having the reassembly buffer entry first.

Testing procedure

Did not add tests yet. Will do (this is why this PR is WIP). Tests were added to tests/gnrc_sixlowpan_frag so it should pass.

Issues/PRs references

None

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Oct 1, 2019
@miri64 miri64 added this to the Release 2020.01 milestone Oct 1, 2019
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 18, 2019

Squashed

@miri64 miri64 force-pushed the gnrc_sixlowpan_frag_rb/enh/new-functions branch from 01726c8 to 5d3d344 Compare October 18, 2019 07:04
@miri64 miri64 removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Oct 18, 2019
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 18, 2019

And rebased.

@miri64 miri64 force-pushed the gnrc_sixlowpan_frag_rb/enh/new-functions branch 2 times, most recently from 89909d1 to c86aec6 Compare October 19, 2019 13:45
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 19, 2019

Rebased to current master to resolve conflicts.

@miri64 miri64 requested a review from benpicco October 19, 2019 13:45
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 19, 2019
benpicco
benpicco approved these changes Oct 19, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The helper functions are pretty straightforward and there are even tests.

IMHO a single big PR that adds SFR with many small commits like this would be easier to handle than many small PRs that add code that is not used yet.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 19, 2019

IMHO a single big PR that adds SFR with many small commits like this would be easier to handle than many small PRs that add code that is not used yet.

And then I wait for ages for that to be merged, because nobody wants to review a >5000 line PR that also changes a lot of 6LoWPAN's APIs.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 19, 2019 •
edited
Loading

IMHO a single big PR that adds SFR with many small commits like this would be easier to handle than many small PRs that add code that is not used yet.

And then I wait for ages for that to be merged, because nobody wants to review a >5000 line PR that also changes a lot of 6LoWPAN's APIs.

+ somebody then needs to test all of this everytime I address a change request in that PR...

@miri64 miri64 force-pushed the gnrc_sixlowpan_frag_rb/enh/new-functions branch from 47140ed to 3cc8b91 Compare October 19, 2019 14:30
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 19, 2019

Squashed as per #12349 (comment)

@benpicco benpicco mentioned this pull request Oct 19, 2019
Closed
@miri64 miri64 merged commit 267dd0b into RIOT-OS:master Oct 19, 2019
@miri64 miri64 deleted the gnrc_sixlowpan_frag_rb/enh/new-functions branch October 19, 2019 15:00
@miri64 miri64 restored the gnrc_sixlowpan_frag_rb/enh/new-functions branch October 31, 2019 18:50
@miri64 miri64 deleted the gnrc_sixlowpan_frag_rb/enh/new-functions branch October 31, 2019 18:52
@miri64 miri64 mentioned this pull request Nov 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

Assignees

No one assigned

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.01

Development

Successfully merging this pull request may close these issues.

2 participants

@miri64 @benpicco