sixlowpan_sfr: initial import Selective Fragment Recovery definitions#12303
sixlowpan_sfr: initial import Selective Fragment Recovery definitions#12303miri64 merged 2 commits intoRIOT-OS:masterfrom
Conversation
|
The headers look good and Murdock will soon confirm that all the tests are running ;) But does it make sense to merge this before there is any code that makes use of this? |
Will be coming in in the coming weeks. It would greatly reduce some rebasing hassle if it were merged (same goes for #12220 ;-)) |
|
I understand the reasoning that keeping PRs small would speed up the review process. I review PRs one commit after the other, so that's already reasonable chunks. |
|
On one hand, many reviewers (myself included) seem to prefer smaller updates as larger PRs just feel overwhelming. On the other, I prefer to get my code published and reviewed fast, so kinks can be ironed out, while I'm still working on follow-ups (which to my understanding are seperate units so should be separate PRs) |
|
Also, in this specific instance the feature is expected to be quite large (think IPv6 fragmentation + reassembly + a lot more extra) so I rather go small logically divided steps. |
|
Added a check to generically check if the header is any of the two SFR headers. |
benpicco
left a comment
There was a problem hiding this comment.
The code looks good and tests ensure it's correctness.
It doesn't do much on it's own though - but if this helps you with the further implementation of Selective Fragment Recovery, go ahead and squash.
7a46809 to
38571c6
Compare
|
Squashed. |
Contribution description
This provides a helper header to parse and set the headers defined in https://tools.ietf.org/html/draft-ietf-6lo-fragment-recovery-05#section-5.
Testing procedure
I provided unittests for this helper header:
Issues/PRs references
None