credman: change credman_buffer_t::s type to 'const void *'#12299
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Sep 24, 2019
Merged
credman: change credman_buffer_t::s type to 'const void *'#12299miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64 merged 1 commit intoRIOT-OS:masterfrom
Conversation
pokgak
pushed a commit
to pokgak/RIOT
that referenced
this pull request
Sep 24, 2019
miri64
added
Area: security
miri64
approved these changes
Sep 24, 2019
Member
miri64
left a comment
miri64
left a comment
There was a problem hiding this comment.
LGTM. The pointer is not supposed to have the value changed and everything should still compile. Let's wait and see Murdock's verdict.
Member
|
and go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This is a fix to the problem described in comment.
Testing procedure
Building #11943 without this change will produce error:
With this change, the error is gone.