Skip to content

boards/stm32f429i-disc1: fix flashing with openocd#12228

Closed
benpicco wants to merge 1 commit intomasterfrom
openocd-stm32f429i-disc1
Closed

boards/stm32f429i-disc1: fix flashing with openocd#12228
benpicco wants to merge 1 commit intomasterfrom
openocd-stm32f429i-disc1

Conversation

@benpicco
Copy link
Copy Markdown
Contributor

@benpicco benpicco commented Sep 14, 2019

Contribution description

At least with openocd 0.10.0, STLINK_VERSION needs to explicitly set to 2 for flashing of this board to work.

Testing procedure

Run make BOARD=stm32f429i-disc1 flash with any application

Issues/PRs references

none

@benpicco
boards/stm32f429i-disc1: fix flashing with openocd
f40815c 
At least with openocd 0.10.0, STLINK_VERSION needs to explicitly set to 2
for flashing of this board to work.
@benpicco benpicco added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports Area: toolchain Area: toolchains; everything related to compilation, libc, linking, … labels Sep 14, 2019
@benpicco benpicco requested a review from aabadie September 14, 2019 10:53
@miri64
Copy link
Copy Markdown
Member

miri64 commented Sep 16, 2019

Any reason why the branch is in the main repository?

@benpicco
Copy link
Copy Markdown
Contributor Author

benpicco commented Sep 16, 2019

Oops, I didn't notice this.

I discovered that the additional parameter was needed when scavenging my drawer for a board to test your PR on. So instead of going back to master, creating a branch, pushing it… I found it easier to just edit the file directly on Github.

Should have selected the option to create the branch in my clone - but this is a minor fix, the branch should be deleted soon anyway.

@toonst
Copy link
Copy Markdown
Member

toonst commented Sep 16, 2019

@benpicco Just FYI: Since 26 Jan 2017 openocd has a common config for all st-links, which is used by default since this PR: #11824. Following the RIOT wiki, it is recommended to use the latest upstream openocd version.

@benpicco
Copy link
Copy Markdown
Contributor Author

benpicco commented Sep 16, 2019

I wish OpenOCD would do another release 😕
OpenOCD 0.10.0 is the latest available release and it's what most distributions will provide.

With that it was necessary to specify the STLINK_VERSION.

I haven't tried with the latest master branch of OpenOCD yet.

@benpicco
Copy link
Copy Markdown
Contributor Author

benpicco commented Sep 23, 2019

FYI: stm32f0discovery, stm32f3discovery, stm32f4discovery and some other also have this.

@benpicco
Copy link
Copy Markdown
Contributor Author

benpicco commented Sep 27, 2019

I just compiled me a fresh OpenOCD and with that it's working, straight off the master branch.

So I guess I can close this.

@benpicco benpicco closed this Sep 27, 2019
@benpicco benpicco deleted the openocd-stm32f429i-disc1 branch September 27, 2019 23:40
@benpicco benpicco mentioned this pull request May 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabadie aabadie Awaiting requested review from aabadie

Assignees

No one assigned

Labels

Area: boards Area: Board ports Area: toolchain Area: toolchains; everything related to compilation, libc, linking, … CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benpicco @miri64 @toonst