murdock: nordic_softdevice_ble: softdevice.hex is a test input#11995
Merged
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom Aug 12, 2019
Merged
murdock: nordic_softdevice_ble: softdevice.hex is a test input#11995MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom
Conversation
MrKevinWeiss
added
CI: run tests
Contributor
Author
|
Damn it is not working as the file as no explicit recipe. |
Contributor
Author
|
I will try a hack to see if it at least works. |
cladmi
force-pushed
the
pr/murdock/softdevice
branch
from
72a17fd to
0a957fb
Compare
Contributor
Author
|
I force-pushed to fix the ordering and have the |
Contributor
Author
|
It did not work in parallel, so I moved the handling to the I currently did it in the |
MrKevinWeiss
added
CI: ready for build
Contributor
Author
|
Now it is working :D |
Contributor
|
Squash please! |
cladmi
force-pushed
the
pr/murdock/softdevice
branch
from
e27c637 to
4cd54f9
Compare
When running tests using 'nordic_softdevice_ble', the 'softdevice.hex' file must also be taken into account for the test hashing and be uploaded to the separated murdock testing boards. When listed as dependency from `test-input-hash` the file must have a target, which he has not. The file is implicitly created when compiling `ELFFILE` so declare it as order only dependency. In practice `BASELIBS` could be enough or even `pkg-build-softdevice` but I do not want to be depend that much on internals there.
cladmi
force-pushed
the
pr/murdock/softdevice
branch
from
4cd54f9 to
e70efb7
Compare
Contributor
Author
|
I squashed and also updated the commit message to take both commits into account. |
Contributor
|
Your the best! |
Contributor
Author
|
Thank you for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
When running tests using 'nordic_softdevice_ble', the 'softdevice.hex'
file must also be taken into account for the test hashing and be
uploaded to the separated murdock testing boards.
Testing procedure
Running test
tests/nordic_softdevicewithnrf52dkshould now work onmurdock.Issues/PRs references
https://ci.riot-os.org/RIOT-OS/RIOT/master/700b121936dc4f39d66d84468fbd31398c9f1ec8/output/run_test/tests/nordic_softdevice/nrf52dk:gnu.txt
#11797 (comment)
#11697 (comment)