Skip to content

make: fix rebuilding on changes without clean or -B#1198

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
Kijewski:issue-1197
May 16, 2014
Merged

make: fix rebuilding on changes without clean or -B#1198
miri64 merged 1 commit intoRIOT-OS:masterfrom
Kijewski:issue-1197

Conversation

@Kijewski
Copy link
Copy Markdown
Contributor

Partial revert of 85b7eca

Fixes #1197.

Partial revert of 85b7eca

Fixes #1197.
@Kijewski
Copy link
Copy Markdown
Contributor Author

We'd need to replace almost every instance of all in the make system with $(ELFFILE) to make the previous idea running. That's not that bad, but we should still use this quick fix until someone digs deeper into that matter.

Pocking @authmillenon.

@OlegHahm
Copy link
Copy Markdown
Member

You wanna challenge @LudwigOrtmann for the worst title of a PR? Point from my side: cannot tell what this about without clicking a further link.

@Kijewski
Copy link
Copy Markdown
Contributor Author

So I win? This is good, isn't it? :P

(title changed)

@Kijewski Kijewski changed the title make: fix #1197 make: fix rebuilding on changes without clean or -B May 16, 2014
@LudwigKnuepfer
Copy link
Copy Markdown
Member

Oh, I didn't see to get the original title AND I can't remember my worst title.

@LudwigKnuepfer
Copy link
Copy Markdown
Member

=(

@Kijewski
Copy link
Copy Markdown
Contributor Author

So, are you gonna review this PR?

@LudwigKnuepfer
Copy link
Copy Markdown
Member

Yes, I'm gonna.

@LudwigKnuepfer
Copy link
Copy Markdown
Member

Seems to work

@LudwigKnuepfer
Copy link
Copy Markdown
Member

So I ACK

@miri64
Copy link
Copy Markdown
Member

miri64 commented May 16, 2014

ACK, status I tried to fix in #1195 is working again.

miri64 added a commit that referenced this pull request May 16, 2014
make: fix rebuilding on changes without `clean` or `-B`
@miri64 miri64 merged commit f8e329b into RIOT-OS:master May 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make: make all does not rebuild anymore if source has changed

4 participants