Skip to content

makefiles/openocd: use stlink.cfg by default#11824

Closed
toonst wants to merge 1 commit intoRIOT-OS:masterfrom
OTAkeys:pr/use_openocd_stlink_cfg
Closed

makefiles/openocd: use stlink.cfg by default#11824
toonst wants to merge 1 commit intoRIOT-OS:masterfrom
OTAkeys:pr/use_openocd_stlink_cfg

Conversation

@toonst
Copy link
Copy Markdown
Member

@toonst toonst commented Jul 10, 2019

Contribution description

stlink-v2-1.cfg is deprecated in openocd. Since 26 Jan 2017 openocd has a common config for all st-links.

This change might break flashing for people who are using stlink with an old openocd and don't define STLINK_VERSION. Is it acceptable to assume RIOT users are using more recent openocd's?

Testing procedure

Flash on an stm board using stlink debugger.

Issues/PRs references

makefiles/openocd: use stlink.cfg by default
e27922e 
stlink-v2-1.cfg is deprecated in openocd, since 26 Jan 2017 openocd has
a common config for all st-links. This change might break flashing for
people who are using stlink with an old openocd and don't define
STLINK_VERSION.
@PeterKietzmann PeterKietzmann added Area: boards Area: Board ports Area: tools Area: Supplementary tools labels Jul 17, 2019
@toonst toonst mentioned this pull request Sep 16, 2019
Closed
@tcschmidt
Copy link
Copy Markdown
Member

tcschmidt commented Oct 11, 2019

Any comment/advise here, @cladmi ?

@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Oct 14, 2019 •
edited
Loading

Maybe deprecated since the 26 of January 2017, but they never did a release since the 22nd

OpenOCD 0.10.0 release is out
January 22nd, 2017

And it has never added in a released version of oppenocd.

Both our current supported ubuntu and any upcoming versions still do not have stlink.cfg.

https://packages.ubuntu.com/bionic/amd64/openocd/filelist
https://packages.ubuntu.com/eoan/amd64/openocd/filelist

If you want to remove the warning, I was thinking that you could do a change like

RIOT/boards/common/stm32/dist/stm32l0.cfg

Lines 2 to 7 in 9bc600a

try {
source [find target/stm32l0_dual_bank.cfg]
} on error {} {
puts "WARNING: Your Openocd version does not support dual bank flash on your board. Falling back to single bank flashing."
source [find target/stm32l0.cfg]
}
but no idea how it would work from command line…

@aabadie aabadie mentioned this pull request Nov 12, 2019
Merged
@benpicco benpicco added the CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs label Mar 13, 2020
@stale
Copy link
Copy Markdown

stale bot commented Apr 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Apr 16, 2020
@stale stale bot closed this May 17, 2020
This was referenced Aug 26, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabadie aabadie Awaiting requested review from aabadie

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

Assignees

No one assigned

Labels

Area: boards Area: Board ports Area: tools Area: Supplementary tools CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs State: stale State: The issue / PR has no activity for >185 days

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@toonst @tcschmidt @cladmi @benpicco @PeterKietzmann