Skip to content

boards/stm32f723e-disco: add initial support#11800

Merged
fjmolinas merged 2 commits intoRIOT-OS:masterfrom
aabadie:pr/boards/stm32f723e-disco
Sep 20, 2019
Merged

boards/stm32f723e-disco: add initial support#11800
fjmolinas merged 2 commits intoRIOT-OS:masterfrom
aabadie:pr/boards/stm32f723e-disco

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Jul 5, 2019

Contribution description

This PR adds a very basic support for the stm32f723e-disco board.
This board provides an nice LCD TFT screen, an Arduino pinout and an STMod+ connector. The STMod+ connector provide an easy way to extend the board with Xbee or other mikrobus compilant devices.
There's also an ESP-01 connector that allows to plug an esp8266 on it and configure wifi using AT commands on the ESP8266.

Only uart, timer, rtc and rtt features are configured at board level for the moment but I plan to extend the pinout support.

There's an issue with uart when using application without stdin: no output can be printed on stdio. The workaround is to use stdin by default with this board. I haven't looked at it further yet.

Testing procedure

Run compile_and_test_for_board.py for this board.

Issues/PRs references

None

@aabadie aabadie added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: boards Area: Board ports labels Jul 5, 2019
@aabadie aabadie requested a review from fjmolinas July 5, 2019 06:50
@aabadie aabadie force-pushed the pr/boards/stm32f723e-disco branch 2 times, most recently from 1b7e8da to 7490cd5 Compare July 5, 2019 21:31
@aabadie aabadie changed the title boards/stm32f723e-disco: add basic initial support (WIP) boards/stm32f723e-disco: add initial support Jul 5, 2019
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 5, 2019
@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Aug 6, 2019

Testing results, a lot of failures:

Failures during test:
- [tests/bloom_bytes](tests/bloom_bytes/test.failed) [hardfaults]
- [tests/float](tests/float/test.failed) [hardfaults]
- [tests/gnrc_ipv6_ext](tests/gnrc_ipv6_ext/test.failed) [sudo]
- [tests/gnrc_rpl_srh](tests/gnrc_rpl_srh/test.failed) [sudo]
- [tests/gnrc_sock_dns](tests/gnrc_sock_dns/test.failed) [sudo]
- [tests/libfixmath_unittests](tests/libfixmath_unittests/test.failed) [hardfaults]
- [tests/pkg_cn-cbor](tests/pkg_cn-cbor/test.failed)  [hardfaults]
- [tests/pkg_lora-serialization](tests/pkg_lora-serialization/test.failed)  [hardfaults]
- [tests/pkg_ubasic](tests/pkg_ubasic/test.failed)  [hardfaults]
- [tests/rng](tests/rng/test.failed) [hardfaults]
- [tests/unittests](tests/unittests/test.failed) [hardfaults]

@aabadie aabadie force-pushed the pr/boards/stm32f723e-disco branch from 7490cd5 to 68014de Compare August 6, 2019 14:04
@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Aug 6, 2019

For the moment, I have no idea why these tests are failing. I noticed they are also failing on nucleo-f746zg but not on nucleo-f767zi.

@fjmolinas fjmolinas mentioned this pull request Aug 6, 2019
Merged
fjmolinas
fjmolinas requested changes Sep 20, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I'm re-running tests. It is missing documentation though.

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Sep 20, 2019

It is missing documentation though.

Indeed....

@aabadie
cpu/stm32f7: add support for stm32f723 cpu line
8bb98ba
@aabadie
boards/stm32f723e-disco: add initial support
80a5e88 
Peripheral configured:
- 5 UARTs for stdio via STLink, Arduino connector, PMOD connector,
STMOD+ connector and ESP-01 connector
- 1 I2C available on Arduino connector and STMOD+ connector
- 2 SPIs available on Arduino connector and PMOD connector
@aabadie aabadie force-pushed the pr/boards/stm32f723e-disco branch from 68014de to 80a5e88 Compare September 20, 2019 11:45
@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Sep 20, 2019

Documentation added @fjmolinas :)

@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Sep 20, 2019

For the moment, I have no idea why these tests are failing. I noticed they are also failing on nucleo-f746zg but not on nucleo-f767zi.

Failing tests seem to be for all stm32f7, if you open an issue we can merge this, since it is unrelated.

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Sep 20, 2019

if you open an issue we can merge this

See #12286

fjmolinas
fjmolinas approved these changes Sep 20, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still failing tests with this PR, but they are common to STM32F7 and not introduced by this supported board. An issue has been opened to address the issue but there is no need to stall this PR because of this. ACK!

@fjmolinas fjmolinas merged commit 04b9268 into RIOT-OS:master Sep 20, 2019
@kb2ma kb2ma added this to the Release 2019.10 milestone Sep 29, 2019
@aabadie aabadie mentioned this pull request Sep 29, 2019
Merged
@aabadie aabadie deleted the pr/boards/stm32f723e-disco branch March 5, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

Assignees

No one assigned

Labels

Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2019.10

Development

Successfully merging this pull request may close these issues.

3 participants

@aabadie @fjmolinas @kb2ma