Skip to content

boards/mips-malta: set FLASHFILE#11711

Merged
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/board/mips-malta/flashfile
Jun 24, 2019
Merged

boards/mips-malta: set FLASHFILE#11711
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/board/mips-malta/flashfile

Conversation

@cladmi
Copy link
Copy Markdown
Contributor

@cladmi cladmi commented Jun 17, 2019

Contribution description

Set FLASHFILE to the file that was generated before.

It still need to have HEXFILE=$(BINFILE) as it cannot generate a hex file.

This will be cleaned up when HEXFILE is not always generated anymore, but depends on all boards being updated to FLASHFILE.

Testing procedure

The board does not have any flasher, so it is only theoretical.

Testing without board

The binfile is used as flashfile and it can be overwritten from the environment.

BOARD=mips-malta make --no-print-directory -C examples/hello-world/ info-debug-variable-FLASHFILE
/home/harter/work/git/RIOT/examples/hello-world/bin/mips-malta/hello-world.bin

FLASHFILE=stout BOARD=mips-malta make --no-print-directory -C examples/hello-world/ info-debug-variable-FLASHFILE
stout

Issues/PRs references

Part of the FLASHFILE introduction #8838

@cladmi cladmi added Area: build system Area: Build system Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: tools Area: Supplementary tools Platform: MIPS Platform: This PR/issue effects MIPS-based platforms labels Jun 17, 2019
@cladmi cladmi added this to the Release 2019.07 milestone Jun 17, 2019
@cladmi cladmi requested a review from MrKevinWeiss June 17, 2019 16:52
@cladmi
boards/mips-malta: set FLASHFILE
78fdc49 
Set FLASHFILE to the file that was generated before.

It still need to have HEXFILE=$(BINFILE) as it cannot generate a hex file.
@cladmi cladmi force-pushed the pr/board/mips-malta/flashfile branch from 709b3e3 to 78fdc49 Compare June 17, 2019 16:52
@cladmi cladmi changed the title boars/mips-malta: set FLASHFILE boards/mips-malta: set FLASHFILE Jun 17, 2019
@cladmi cladmi mentioned this pull request Jun 17, 2019
Merged
49 tasks
MrKevinWeiss
MrKevinWeiss approved these changes Jun 24, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the board but it looks OK and seems very low risk. It should be good for uniformity and it is documented. I suppose if other people have there own flashers it is good not to overwrite hexfile.
ACK!

@MrKevinWeiss MrKevinWeiss merged commit dec51aa into RIOT-OS:master Jun 24, 2019
@cladmi
Copy link
Copy Markdown
Contributor Author

cladmi commented Jun 25, 2019

Thank you for the review.

@cladmi cladmi deleted the pr/board/mips-malta/flashfile branch June 25, 2019 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

Assignees

No one assigned

Labels

Area: build system Area: Build system Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: MIPS Platform: This PR/issue effects MIPS-based platforms

Projects

None yet

Milestone

Release 2019.07

Development

Successfully merging this pull request may close these issues.

2 participants

@cladmi @MrKevinWeiss