makefiles/murdock.inc.mk: change policy to run tests by default by cladmi · Pull Request #11680 · RIOT-OS/RIOT

cladmi · 2019-06-12T13:43:16Z

Contribution description

Change the policy to run the tests by default on murdock.

Introduce TEST_ON_CI_BLACKLIST for describing tests that must not be
run in CI.

By default if a test is available and not blacklisted it will be run by
murdock.

This will move from a whitelisting everything that works, to
blacklisting what fails. This way, failing tests will be easier to
track instead of being silently just not run.

It could even allow introducing failing tests before a fix is available.

TODO

This pull request will require blacklisting all what fails in a commit before changing the policy.

Update the remaining TEST_ON_CI_WHITELIST with the reason.

git grep 'TEST_ON_CI_WHITELIST' '*' ':!makefiles/murdock.inc.mk'
tests/libfixmath_unittests/Makefile:TEST_ON_CI_WHITELIST += native
tests/pkg_libcose/Makefile:TEST_ON_CI_WHITELIST += native
tests/pkg_tweetnacl/Makefile:TEST_ON_CI_WHITELIST += native
tests/rng/Makefile:TEST_ON_CI_WHITELIST += native

An followup will be to update dist/tools/compile_an_test_for_board.py to maybe not handle a failure as FAILED but more expected failure if the test was not enabled.
Followup with a command to list all disabled tests in RIOT

Testing procedure

New behavior

If there is a test and nothing is set the board is enabled

BOARD=samr21-xpro make --no-print-directory -C tests/pkg_fatfs_vfs/ test/available test-on-ci-enabled

Blacklisting

If all is blacklisted, no test will be run

BOARD=native make --no-print-directory -C tests/pkg_fatfs_vfs/ test/available test-on-ci-enabled 
/home/harter/work/git/RIOT/makefiles/murdock.inc.mk:47: recipe for target 'test-on-ci-enabled' failed
make: *** [test-on-ci-enabled] Error 1
BOARD=samr21-xpro make --no-print-directory -C tests/pkg_fatfs_vfs/ test/available test-on-ci-enabled 
/home/harter/work/git/RIOT/makefiles/murdock.inc.mk:47: recipe for target 'test-on-ci-enabled' failed
make: *** [test-on-ci-enabled] Error 1

diff --git a/tests/pkg_fatfs_vfs/Makefile b/tests/pkg_fatfs_vfs/Makefile
index edbf14bf4..babd1db3c 100644
--- a/tests/pkg_fatfs_vfs/Makefile
+++ b/tests/pkg_fatfs_vfs/Makefile
@@ -50,6 +50,8 @@ BOARD_WHITELIST := airfy-beacon arduino-due arduino-duemilanove \
 
 TEST_DEPS += image
 
+TEST_ON_CI_BLACKLIST += all
+
 include $(RIOTBASE)/Makefile.include
 
 image:

If one board is blacklisted only this one will not run

BOARD=native make --no-print-directory -C tests/pkg_fatfs_vfs/ test/available test-on-ci-enabled 
BOARD=samr21-xpro make --no-print-directory -C tests/pkg_fatfs_vfs/ test/available test-on-ci-enabled 
/home/harter/work/git/RIOT/makefiles/murdock.inc.mk:47: recipe for target 'test-on-ci-enabled' failed
make: *** [test-on-ci-enabled] Error 1

with this diff

diff --git a/tests/pkg_fatfs_vfs/Makefile b/tests/pkg_fatfs_vfs/Makefile
index edbf14bf4..d44376293 100644
--- a/tests/pkg_fatfs_vfs/Makefile
+++ b/tests/pkg_fatfs_vfs/Makefile
@@ -50,6 +50,8 @@ BOARD_WHITELIST := airfy-beacon arduino-due arduino-duemilanove \
 
 TEST_DEPS += image
 
+TEST_ON_CI_BLACKLIST += samr21-xpro
+
 include $(RIOTBASE)/Makefile.include
 
 image:

Kept behavior when `TEST_ON_CI_WHITELIST` is set

The previous behavior when WHITELIST is set did not change.

Enabled tests are still enabled:

# Only native enabled
BOARD=native make --no-print-directory -C tests/libfixmath_unittests/ test-on-ci-enabled
# all enabled
BOARD=samr21-xpro make --no-print-directory -C tests/bloom_bytes/ test-on-ci-enabled
BOARD=iotlab-m3 make --no-print-directory -C tests/bloom_bytes/ test-on-ci-enabled

Not enabled tests are still not enabled

BOARD=samr21-xpro make --no-print-directory -C tests/libfixmath_unittests/ test-on-ci-enabled 
/home/harter/work/git/RIOT/makefiles/murdock.inc.mk:47: recipe for target 'test-on-ci-enabled' failed
make: *** [test-on-ci-enabled] Error 1

If a board does not have enough memory, it is still disabled

RIOT_CI_BUILD=1 BOARD=samr21-xpro make --no-print-directory -C tests/unittests/ test-on-ci-enabled 
CI-build: skipping link step
/home/harter/work/git/RIOT/makefiles/murdock.inc.mk:47: recipe for target 'test-on-ci-enabled' failed
make: *** [test-on-ci-enabled] Error 1

Issues/PRs references

#11128 (comment)
Some tests always fail on some boards, even some supported for testing in CI RIOT-OS/Release-Specs#98 (comment)

cladmi · 2019-06-12T16:40:30Z

Currently

tests/lwip crashes, but it also fails on my machine.
tests/socket_zep works on my machine but not on murdock
tests/lua_loader, tests/pkg_u8g3, tests/pthread_rwlock work on my machine but not on murdock. Are the worker running with an ascii console ?

cladmi · 2019-06-13T09:41:35Z

With "cache enabled" the test report is not included for the previous ones. So must re-run it.

cladmi · 2019-08-12T09:51:28Z

Rebased and removed the dependency to the fix in #11688 by currently just blacklisting the test. Fixing is a different task.

jcarrano

I think this is the way to go with tests. This needs squashing.

cladmi · 2019-08-20T15:24:45Z

This one is touching similar files as #11688 Should I rebase the other one on top of this one ? At least the conflicting commit.

kaspar030 · 2019-08-21T10:37:42Z

This one is touching similar files as #11688 Should I rebase the other one on top of this one ? At least the conflicting commit.

IMO this one is larger and should get in first. Please squash!

HACK, the test currently fails in CI for `native` due to `utf-8` handling. HACK, the test implementation can fail due being de-scheduled during printf.

HACK, blacklist native as it fails to create a tun interface in murdock.

HACK, the test currently fails in CI for 'native' due to binding issue

Disable running tests that need a setup and run with root as they cannot currently be run in CI.

The test need a manual setup that cannot currently be done in CI.

The test fails on both murdock and on my machine due to the process exiting directly. pexpect.exceptions.EOF: End Of File (EOF). Exception style platform.

Only set `TEST_ON_CI_ENABLED` if the application has tests. Currently `TEST_ON_CI_WHITELIST` was only set if there were tests. This is a pre-step to have `TEST_ON_CI_WHITELIST` being `all` by default.

By default if a test is available and not blacklisted it will be run by murdock. This will move from a whitelisting everything that works, to blacklisting what fails. This way, failing tests will be easier to track instead of being silently just not run. It could even allow introducing failing tests before a fix is available.

This is now the default so not required anymore.

cladmi · 2019-08-21T10:56:52Z

Squashed with test blacklisting first.

When enabling all tests by default, some additional tests will be run (if compatible) as I did not add TEST_ON_CI_WHITELIST += all in all directory before doing it.

Lets check no failing tests were introduced in between.

kaspar030 · 2019-08-21T13:32:26Z

ACK. This ran 511 tests (compared to 447 last nightly). &go.

cladmi · 2019-08-21T13:36:08Z

Thank you for the review.

Now I can do the TODO further work.

cladmi added this to the Release 2019.07 milestone Jun 12, 2019

cladmi requested review from MrKevinWeiss, aabadie, jcarrano, kaspar030, miri64 and smlng June 12, 2019 13:43

cladmi removed the CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before label Jun 12, 2019

cladmi mentioned this pull request Jun 13, 2019

tests/lua_loader: remove deprecated test target #11685

Merged

cladmi added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 13, 2019

This was referenced Jun 13, 2019

tests/lua_loader: run the test in CI #11686

Merged

tests/pkg_u8g2: run the test in CI #11687

Merged

tests/pthread_rwlock: run the test in CI #11688

Merged

cladmi force-pushed the pr/ci/change_testing_policy branch from b280758 to bae6014 Compare June 25, 2019 16:55

cladmi mentioned this pull request Jun 25, 2019

murdock: introduce 'TEST_ON_CI_BLACKLIST' #11743

Merged

cladmi force-pushed the pr/ci/change_testing_policy branch 3 times, most recently from aa10a5e to 3af3849 Compare July 12, 2019 16:49

cladmi force-pushed the pr/ci/change_testing_policy branch from fe47d84 to 866d26f Compare August 12, 2019 09:50

cladmi force-pushed the pr/ci/change_testing_policy branch from 605f461 to 46ec352 Compare August 12, 2019 10:04

jcarrano added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Aug 20, 2019

jcarrano approved these changes Aug 20, 2019

View reviewed changes

cladmi mentioned this pull request Aug 20, 2019

tests/cpp_ctors: move tests-cpp_ctors out of unittests #12040

Merged

cladmi added 3 commits August 21, 2019 12:40

tests/pthread_rwlock: run the test in CI

622fe2c

HACK, the test currently fails in CI for `native` due to `utf-8` handling. HACK, the test implementation can fail due being de-scheduled during printf.

tests/netstats_l2: run the test in CI

095268a

HACK, blacklist native as it fails to create a tun interface in murdock.

tests/socket_zep: define TEST_ON_CI_BLACKLIST

12d4b71

HACK, the test currently fails in CI for 'native' due to binding issue

cladmi force-pushed the pr/ci/change_testing_policy branch from 46ec352 to 75e6f7f Compare August 21, 2019 10:43

cladmi added 5 commits August 21, 2019 12:46

tests/gnrc: disable tests that need setup and root

f7176f4

Disable running tests that need a setup and run with root as they cannot currently be run in CI.

tests/pkg_fatfs_vfs: disable tests that need setup

1f11843

The test need a manual setup that cannot currently be done in CI.

tests/lwip: disable failing test

084c6f7

The test fails on both murdock and on my machine due to the process exiting directly. pexpect.exceptions.EOF: End Of File (EOF). Exception style platform.

murdock: only set test is enabled if there are tests

1e6ac08

Only set `TEST_ON_CI_ENABLED` if the application has tests. Currently `TEST_ON_CI_WHITELIST` was only set if there were tests. This is a pre-step to have `TEST_ON_CI_WHITELIST` being `all` by default.

cladmi force-pushed the pr/ci/change_testing_policy branch from 7bf0659 to d6dedd9 Compare August 21, 2019 10:51

applications: remove 'TEST_ON_CI_WHITELIST += all'

8e5422f

This is now the default so not required anymore.

cladmi force-pushed the pr/ci/change_testing_policy branch from d6dedd9 to 8e5422f Compare August 21, 2019 10:51

kaspar030 merged commit 8f7009e into RIOT-OS:master Aug 21, 2019

cladmi deleted the pr/ci/change_testing_policy branch August 21, 2019 13:37

kaspar030 mentioned this pull request Sep 9, 2019

sys/log: add module for colorized logging #11573

Merged

kb2ma added this to the Release 2019.10 milestone Sep 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

makefiles/murdock.inc.mk: change policy to run tests by default#11680

makefiles/murdock.inc.mk: change policy to run tests by default#11680
kaspar030 merged 9 commits intoRIOT-OS:masterfrom
cladmi:pr/ci/change_testing_policy

cladmi commented Jun 12, 2019 •

edited

Loading

Uh oh!

cladmi commented Jun 12, 2019

Uh oh!

cladmi commented Jun 13, 2019

Uh oh!

cladmi commented Aug 12, 2019

Uh oh!

jcarrano left a comment

Uh oh!

cladmi commented Aug 20, 2019 •

edited

Loading

Uh oh!

kaspar030 commented Aug 21, 2019

Uh oh!

cladmi commented Aug 21, 2019

Uh oh!

kaspar030 commented Aug 21, 2019

Uh oh!

cladmi commented Aug 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

cladmi commented Jun 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution description

TODO

Testing procedure

New behavior

Blacklisting

Kept behavior when TEST_ON_CI_WHITELIST is set

Issues/PRs references

Uh oh!

cladmi commented Jun 12, 2019

Uh oh!

cladmi commented Jun 13, 2019

Uh oh!

cladmi commented Aug 12, 2019

Uh oh!

jcarrano left a comment

Choose a reason for hiding this comment

Uh oh!

cladmi commented Aug 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kaspar030 commented Aug 21, 2019

Uh oh!

cladmi commented Aug 21, 2019

Uh oh!

kaspar030 commented Aug 21, 2019

Uh oh!

cladmi commented Aug 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cladmi commented Jun 12, 2019 •

edited

Loading

Kept behavior when `TEST_ON_CI_WHITELIST` is set

cladmi commented Aug 20, 2019 •

edited

Loading