sys/stdio_ethos: replace USE_ETHOS_FOR_STDIO by stdio_ethos pseudomodule#11668
sys/stdio_ethos: replace USE_ETHOS_FOR_STDIO by stdio_ethos pseudomodule#11668kaspar030 merged 5 commits intoRIOT-OS:masterfrom
Conversation
aabadie
added
Area: network
There was a problem hiding this comment.
It would be nice to have it implemented without #11598 as this one could be done by adding stdio_uart_rx dependency alone.
Some minor remarks inline.
Further steps for other pull requests.
From the implementation, it looks like stdio_ethos should be moved to its own module like stdio_rtt. But it is another task that requires many changes.
Also the code is doing implicit circular dependency, the code in drivers/ethos for stdio references variables defined in stdio_uart…
drivers/ethos/ethos.c:extern isrpipe_t stdio_uart_isrpipe;
Once #11598 is merged (and I hope it will be soon), there will be no need to rework this one. Let's finish #11598, which will fix #11525 btw, and continue improving other things afterwards. |
kaspar030
left a comment
kaspar030
left a comment
There was a problem hiding this comment.
Almost good to go. Please add the missing "stdio_uart" dependency.
|
please rebase |
kaspar030
removed
the
State: waiting for other PR
aabadie
force-pushed
the
pr/sys/stdio_ethos
branch
from
5c3555a to
2859849
Compare
|
Please squash! |
aabadie
force-pushed
the
pr/sys/stdio_ethos
branch
from
d53c85b to
5e2f267
Compare
|
squashed! |
aabadie
added
the
CI: ready for build
kaspar030
added
the
CI: run tests
kaspar030
left a comment
kaspar030
left a comment
There was a problem hiding this comment.
ACK.
I found another reference of USE_ETHOS_STDIO in ethos' own README.md and pushed a commit that updates it.
Please take a quick look.
Otherwise I tested that gnrc_border_router still works using make term.
kaspar030
dismissed
cladmi’s stale review
Comments have been addressed, reviewer on holidays. Thx @cladmi!
Looks good. Thanks! |
3 participants
Contribution description
This PR provides a new module
stdio_ethosas a replacement forUSE_ETHOS_FOR_STDIO. Applications using this macro now depends on this new module.stdio_ethosalso depends on the ethos and stdin, provided in #11598.Testing procedure
examples/gnrc_border_routershould still workstdio_ethos:tests/riotboot_flashwrite,tests/gnrc_ipv6_ext,tests/gnrc_rpl_srhandtests/gnrc_sock_dns.Issues/PRs references
Based on #11598