Skip to content

sys/bluetil: add bluetil_addr_from_str()#11640

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:add_bluetil_addrfromstr
Jun 6, 2019
Merged

sys/bluetil: add bluetil_addr_from_str()#11640
miri64 merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:add_bluetil_addrfromstr

Conversation

@haukepetersen
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen commented Jun 6, 2019

Contribution description

This PR adds a function to the bluetil/addr helper module for parsing BLE link layer addresses from a string (xx:xx:xx:xx:xx:xx).

Should be simple and straight forward.

Testing procedure

#11578 is reabsed on this PR. So to test this function, flash the examples/nimble_gnrc application to any supported board and run the ble connect BLE_ADDR shell command.

Issues/PRs references

needed for #11578

@haukepetersen haukepetersen added Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: BLE Area: Bluetooth Low Energy support labels Jun 6, 2019
@haukepetersen haukepetersen mentioned this pull request Jun 6, 2019
Merged
miri64
miri64 approved these changes Jun 6, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, though it basically identical in function to size_t gnrc_netif_addr_from_str(), I can understand that there you don't want to depend on that. Maybe we can consolodate somewhere outside at a later point.

miri64
miri64 reviewed Jun 6, 2019
View reviewed changes
sys/include/net/bluetil/addr.h Outdated
/**
* @brief Parse a BLE address from the given string
*
* @param[in] add_str address string, must be at least of length
Copy link
Copy Markdown
Member

@miri64 miri64 Jun 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis reports: addr parameter missing. Also (nit-picky) why not addr_str?

Copy link
Copy Markdown
Contributor Author

@haukepetersen haukepetersen Jun 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. The add_str was simply a typo, in the c file I already used addr_str :-)

@haukepetersen haukepetersen force-pushed the add_bluetil_addrfromstr branch from e2e72b2 to 665b1d6 Compare June 6, 2019 09:43
@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Jun 6, 2019

addressed doc fix issues and squashed.

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Jun 6, 2019

Maybe we can consolodate somewhere outside at a later point.

Would probably make sense. Maybe move this somehow to the euiXX headers? Not quite sure about this, though.

@miri64 miri64 merged commit 7e7e17c into RIOT-OS:master Jun 6, 2019
@miri64
Copy link
Copy Markdown
Member

miri64 commented Jun 6, 2019

Maybe we can consolodate somewhere outside at a later point.

Would probably make sense. Maybe move this somehow to the euiXX headers? Not quite sure about this, though.

Yeah, but that would require C-files for those modules... l2util does not seem to be the right place either, but is the closest..

@haukepetersen haukepetersen deleted the add_bluetil_addrfromstr branch June 6, 2019 10:34
@MrKevinWeiss MrKevinWeiss added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

No one assigned

Labels

Area: BLE Area: Bluetooth Low Energy support CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@haukepetersen @miri64 @MrKevinWeiss