Skip to content

boards/lobaro-lorabox: use FLASHFILE for boards using stm32loader.py#11629

Merged
leandrolanzieri merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/boards/lobaro-lorabox-flashfile
Jun 5, 2019
Merged

boards/lobaro-lorabox: use FLASHFILE for boards using stm32loader.py#11629
leandrolanzieri merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/boards/lobaro-lorabox-flashfile

Conversation

@cladmi
Copy link
Copy Markdown
Contributor

@cladmi cladmi commented Jun 4, 2019

Contribution description

Update to use FLASHFILE as file to be flashed on the board.

Testing procedure

The board can still be flashed as before

Review without the board

The FFLAGS did not change from master:

BOARD=lobaro-lorabox make --no-print-directory -C examples/hello-world/ FLASHER=true flash-only
true -p /dev/ttyUSB0 -e -u -S -l 0x1ff -w /home/harter/work/git/RIOT/examples/hello-world/bin/lobaro-lorabox/hello-world.bin

The FLASHFILE can be configured from the command line

FLASHFILE='$(ELFFILE)' BOARD=lobaro-lorabox make --no-print-directory -C examples/hello-world/ FLASHER=true flash-only
true -p /dev/ttyUSB0 -e -u -S -l 0x1ff -w /home/harter/work/git/RIOT/examples/hello-world/bin/lobaro-lorabox/hello-world.elf

Issues/PRs references

This is part of adding support for FLASHFILE #8838

@cladmi
boards/lobaro-lorabox: use FLASHFILE for boards using stm32loader.py
84d7e37 
Update to use FLASHFILE as file to be flashed on the board.
@cladmi cladmi added Area: build system Area: Build system Area: tools Area: Supplementary tools Area: boards Area: Board ports labels Jun 4, 2019
@cladmi cladmi added this to the Release 2019.07 milestone Jun 4, 2019
@cladmi cladmi requested a review from leandrolanzieri June 4, 2019 14:42
@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 5, 2019
leandrolanzieri
leandrolanzieri approved these changes Jun 5, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all looks good. ACK.

@leandrolanzieri leandrolanzieri merged commit 8068a83 into RIOT-OS:master Jun 5, 2019
@cladmi
Copy link
Copy Markdown
Contributor Author

cladmi commented Jun 5, 2019

Thank you for the review.

@cladmi cladmi deleted the pr/boards/lobaro-lorabox-flashfile branch June 5, 2019 12:10
@cladmi cladmi mentioned this pull request Jun 5, 2019
Merged
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

Assignees

No one assigned

Labels

Area: boards Area: Board ports Area: build system Area: Build system Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines

Projects

None yet

Milestone

Release 2019.07

Development

Successfully merging this pull request may close these issues.

2 participants

@cladmi @leandrolanzieri