gnrc_ipv6_ext: fix packet snip type for header build function#11622
Merged
haukepetersen merged 1 commit intoRIOT-OS:masterfrom Jun 4, 2019
Merged
gnrc_ipv6_ext: fix packet snip type for header build function#11622haukepetersen merged 1 commit intoRIOT-OS:masterfrom
haukepetersen merged 1 commit intoRIOT-OS:masterfrom
Conversation
The `pkt->type` of an extension header should be `GNRC_NETTYPE_IPV6_EXT` so it can be parsed properly as an extension after building.
miri64
added
Area: network
haukepetersen
approved these changes
Jun 4, 2019
Contributor
haukepetersen
left a comment
haukepetersen
left a comment
There was a problem hiding this comment.
I trust my eyes (and understanding) -> ACK
Contributor
|
all green -> go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The
pkt->typeof an extension header should beGNRC_NETTYPE_IPV6_EXTso it can be parsed properly as an extension after building. I noticed this while porting IPv6 fragmentation, the first user of this function (not considering #7231) when merged.Testing procedure
There are no tests for this function, but also no users. So you have to rely on your eyes ;-).
tests/gnrc_ipv6_extshould still compile.Issues/PRs references
None