Skip to content

gnrc_sixlowpan_frag: fix timeout config macro name#11577

Merged
cgundogan merged 1 commit intoRIOT-OS:masterfrom
miri64:gnrc_sixlowpan_frag/fix/ms-to-us
May 25, 2019
Merged

gnrc_sixlowpan_frag: fix timeout config macro name#11577
cgundogan merged 1 commit intoRIOT-OS:masterfrom
miri64:gnrc_sixlowpan_frag/fix/ms-to-us

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented May 24, 2019

Contribution description

As @cgundogan rightly pointed out in #11442 (comment), the macro is misnamed as it is defining the timeout in microseconds (μs or us) not milliseconds (ms).

Testing procedure

gnrc_sixlowpan_frag should still compile (e.g. when building gnrc_networking for an IEEE 802.15.4-based platform).

Issues/PRs references

None, but pointed out in #11442.

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR TF: Config Marks issues and PRs related to the work of the Configuration Task Force labels May 24, 2019
@miri64 miri64 added this to the Release 2019.07 milestone May 24, 2019
@miri64 miri64 requested review from cgundogan and jia200x May 24, 2019 15:42
cgundogan
cgundogan approved these changes May 25, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@cgundogan cgundogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. ACK

@cgundogan cgundogan added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels May 25, 2019
@cgundogan cgundogan merged commit e7ec7a2 into RIOT-OS:master May 25, 2019
@miri64 miri64 deleted the gnrc_sixlowpan_frag/fix/ms-to-us branch May 25, 2019 07:49
@miri64 miri64 mentioned this pull request Jul 12, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgundogan cgundogan cgundogan approved these changes

@jia200x jia200x Awaiting requested review from jia200x

Assignees

No one assigned

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines TF: Config Marks issues and PRs related to the work of the Configuration Task Force Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2019.07

Development

Successfully merging this pull request may close these issues.

2 participants

@miri64 @cgundogan