Skip to content

makefiles/docker: export BOARDS#11385

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
kaspar030:docker_export_boards
May 6, 2019
Merged

makefiles/docker: export BOARDS#11385
miri64 merged 1 commit intoRIOT-OS:masterfrom
kaspar030:docker_export_boards

Conversation

@kaspar030
Copy link
Copy Markdown
Contributor

Contribution description

This enables "BUILD_IN_DOCKER=1 BOARDS='foo bar' make buildtest".
Without this line, when executed with BUILD_IN_DOCKER, "make buildtest"
would always build all boards.

Testing procedure

BUILD_IN_DOCKER=1 BOARDS="samr21-xpro arduino-uno" make -Cexamples/hello-world buildtest

On master, this builds all boards. With this PR, only the two selected.

Issues/PRs references

RIOT-OS/riotdocker#72

This enables "BUILD_IN_DOCKER=1 BOARDS='foo bar' make buildtest".
Without this line, when executed with BUILD_IN_DOCKER, "make buildtest"
would always build all boards.
@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 12, 2019
@kaspar030 kaspar030 requested a review from miri64 April 12, 2019 07:27
@kaspar030 kaspar030 requested a review from cladmi May 6, 2019 11:45
@kaspar030
Copy link
Copy Markdown
Contributor Author

ping this should be a low-hanging fruit.

Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed.

@miri64 miri64 merged commit c50eebe into RIOT-OS:master May 6, 2019
@kaspar030 kaspar030 deleted the docker_export_boards branch July 5, 2019 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants