cpu: Moved stdio_init() prior to periph_init() for ARM targets by maribu · Pull Request #11367 · RIOT-OS/RIOT

maribu · 2019-04-10T09:32:08Z

Contribution description

In current RIOT master stdio_init() is called via newlib's _init(), which is way too late during boot up to allow DEBUG()ing during periph_init(). This PR moves stdio_init() into cpu_init() just before periph_init() is called.

Testing procedure

Flash and run examples/default and interact with the shell. Input and output should still work as expected.

Boards using these CPUs:

Boards with custom/weird boot up sequence:

Board msba2 (@maribu)

Issues/PRs references

Spun out of / partly replaces #10806

dylad

Missing changes in cpu/saml21/cpu.c

maribu · 2019-05-24T10:20:27Z

@dylad: Thanks for pointing that out. The latest fixup should address this :-)

dylad · 2019-05-24T11:22:29Z

@maribu
kinetis are also missing. I think this is the last missing family.

maribu · 2019-05-24T11:55:07Z

kinetis are also missing. I think this is the last missing family.

Done. Thanks for spotting that!

dylad · 2019-06-05T20:20:05Z

@kaspar030 @MrKevinWeiss @smlng @aabadie @basilfx
May I ask you some help with testing there ? I know you own some of the listed boards ;)
This should be pretty straightforward !

MrKevinWeiss · 2019-06-06T08:12:27Z

I will add it to the list!

dylad · 2019-06-06T15:28:58Z

@maribu Could you rebased this PR please ?
with #11305 merged, a new MCU has been introduce so this PR needs to adapt it.
I have the board so I'll be happy to test it with this PR !

maribu · 2019-06-06T15:39:17Z

@dylad: Thanks for pointing that out. I rebased and added the call to stdio_init() to samd5x initialization code as well :-)

dylad · 2019-06-06T15:44:32Z

@maribu Wow so fast thanks !
I can confirm this works on this new MCU.

dylad · 2019-06-19T07:19:27Z

ping
This would be a nice addition to the incoming release

MrKevinWeiss · 2019-06-19T08:09:33Z

Hmmm, I am a bit busy now. I'll set a reminder for tomorrow morning.

maribu · 2019-06-19T10:57:36Z

@dylad: May I squash and rebase to solve the merge conflict?

dylad · 2019-06-19T12:23:27Z

@maribu I'm fine with that.

MrKevinWeiss · 2019-06-20T09:03:17Z

Tested on boards labeled above, I flashed default, asked for help, it replied. There have been some issues after the very first flash but a reset after seemed to fix all problems. I was not able to reproduce any issues after so it may be just the initial connection (a lot of fresh boards with manufacture firmware on them)

MrKevinWeiss · 2019-06-20T09:07:57Z

I guess some work on kinetis cpus are still needed.

dylad · 2019-06-20T11:42:57Z

maybe @fjmolinas could help us with Kinetis there ?

benemorius · 2019-06-20T11:45:31Z

Looks like Kinetis is just missing the include for stdio_base.h

maribu · 2019-06-20T12:44:56Z

I guess some work on kinetis cpus are still needed.

Done

Looks like Kinetis is just missing the include for stdio_base.h

Yes, I don't know why I forgot that :-/

fjmolinas

ACK on my side.
Work on all (tested) platforms.
Changes look good for untested platforms (ezr32wg and lm4f120)
kinetis-ea shared the same code with others kinetis.
I think it is time to go.

Agree, ACK on my side too.

kaspar030 · 2019-09-09T13:19:03Z

This'll make not using stdio a bit more difficult. Before, not using the newlib module was enough to disable stdio. Now we'll have to add guards at multiple points.

Given the time this was waiting, I'm OK with dealing with that when we get there. ;)

maribu · 2019-09-09T13:21:36Z

This'll make not using stdio a bit more difficult. Before, not using the newlib module was enough to disable stdio. Now we'll have to add guards at multiple points.

Why not just overwrite stdio_init() with a nop?

OYTIS · 2019-09-09T13:26:50Z

@fjmolinas Sorry, I don't have the board at my disposal any more.

@smlng I believe you've ordered one S9KEAZ128 board for you haven't you?

kaspar030 · 2019-09-09T13:40:33Z

Why not just overwrite stdio_init() with a nop?

That's a good idea. Anyhow, unrelated!

maribu · 2019-09-09T13:52:00Z

Merge?

benpicco · 2019-09-13T22:48:52Z

This breaks stdio on esp32 & esp8266 😞
It's also pretty weird to have stdio_init() in boards/ for msba2.

msp430, fe310, atmega, mips… was forgotten by this PR too, I'd assume stdio is broken there too now.

maribu · 2019-09-14T08:47:08Z

If I remeber correctly, only the ESP32, the ESP8266, and RISC-V is also using newlib. I'll create PRs eith fixes for those three tonight.

- This guarantees that DEBUG() is available early in boot process - Forgotten in RIOT-OS#11367, fixes broken stdio

- This guarantees that DEBUG() is available early in boot process - Forgotten in RIOT-OS#11367, this fixes broken stdio

- This guarantees that DEBUG() is available early in boot process - Forgotten in RIOT-OS#11367, this fixes broken i stdio

maribu · 2019-09-14T09:31:05Z

OK, the PRs with the fixes are online

Fixed bug introduced in RIOT-OS#11367

maribu · 2019-09-14T09:44:15Z

OK, MIPS32 was the last user of newlib. That should be the last missing fix.

- This guarantees that DEBUG() is available early in boot process - Forgotten in RIOT-OS#11367, this fixes broken stdio

- This guarantees that DEBUG() is available early in boot process - Forgotten in RIOT-OS#11367, this fixes broken i stdio

maribu added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Apr 10, 2019

maribu requested review from dylad, haukepetersen, kaspar030 and vincent-d April 10, 2019 09:32

dylad added this to the Release 2019.07 milestone May 23, 2019

dylad requested changes May 24, 2019

View reviewed changes

MrKevinWeiss self-requested a review June 6, 2019 08:12

maribu force-pushed the arm_early_stdio branch from 369a786 to adeef37 Compare June 6, 2019 15:35

maribu force-pushed the arm_early_stdio branch from 150e41d to 40e72fc Compare June 19, 2019 12:58

maribu added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 19, 2019

maribu removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 20, 2019

dylad added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 9, 2019

fjmolinas approved these changes Sep 9, 2019

View reviewed changes

kaspar030 merged commit 88e07c0 into RIOT-OS:master Sep 9, 2019

maribu deleted the arm_early_stdio branch September 9, 2019 13:53

benpicco mentioned this pull request Sep 13, 2019

Fix stdio on platforms left out by "cpu: Moved stdio_init() prior to periph_init() for ARM targets" #12223

Closed

maribu added a commit to maribu/RIOT that referenced this pull request Sep 14, 2019

cpu/esp32: Moved stdio_init() before periph_init()

2750dc2

- This guarantees that DEBUG() is available early in boot process - Forgotten in RIOT-OS#11367, fixes broken stdio

maribu mentioned this pull request Sep 14, 2019

cpu/esp32: Moved stdio_init() before periph_init() #12224

Merged

maribu added a commit to maribu/RIOT that referenced this pull request Sep 14, 2019

cpu/esp8266: Moved stdio_init before periph_init

2923864

- This guarantees that DEBUG() is available early in boot process - Forgotten in RIOT-OS#11367, this fixes broken stdio

maribu mentioned this pull request Sep 14, 2019

cpu/esp8266: Moved stdio_init before periph_init #12225

Merged

maribu added a commit to maribu/RIOT that referenced this pull request Sep 14, 2019

cpu/fe310: Moved stdio_init() before periph_init()

89031d1

- This guarantees that DEBUG() is available early in boot process - Forgotten in RIOT-OS#11367, this fixes broken i stdio

maribu mentioned this pull request Sep 14, 2019

cpu/fe310: Moved stdio_init() before periph_init() #12226

Closed

maribu added a commit to maribu/RIOT that referenced this pull request Sep 14, 2019

cpu/mips32_r2_common: Added call to stdio_init()

9f0620b

Fixed bug introduced in RIOT-OS#11367

maribu mentioned this pull request Sep 14, 2019

cpu/mips32r2_common: Added call to stdio_init() #12227

Merged

maribu added a commit to maribu/RIOT that referenced this pull request Sep 14, 2019

cpu/mips32r2_common: Added call to stdio_init()

5fd6652

Fixed bug introduced in RIOT-OS#11367

maribu added a commit to maribu/RIOT that referenced this pull request Sep 14, 2019

cpu/esp8266: Moved stdio_init before periph_init

baf911b

- This guarantees that DEBUG() is available early in boot process - Forgotten in RIOT-OS#11367, this fixes broken stdio

benpicco mentioned this pull request Sep 14, 2019

cpu/lpc2387: clean up the platform #12229

Merged

francois-berder pushed a commit to francois-berder/RIOT that referenced this pull request Sep 14, 2019

cpu/esp8266: Moved stdio_init before periph_init

0513169

- This guarantees that DEBUG() is available early in boot process - Forgotten in RIOT-OS#11367, this fixes broken stdio

benpicco mentioned this pull request Sep 15, 2019

TI CC3200 SimpleLink RIOT support #11866

Closed

kb2ma added this to the Release 2019.10 milestone Sep 16, 2019

kaspar030 pushed a commit to kaspar030/RIOT that referenced this pull request Sep 16, 2019

cpu/fe310: Moved stdio_init() before periph_init()

2433d10

- This guarantees that DEBUG() is available early in boot process - Forgotten in RIOT-OS#11367, this fixes broken i stdio

maribu mentioned this pull request Jan 31, 2020

stdio_init happens late during boot #10645

Closed

Conversation

maribu commented Apr 10, 2019 • edited by dylad Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution description

Testing procedure

Issues/PRs references

Uh oh!

dylad left a comment

Choose a reason for hiding this comment

Uh oh!

maribu commented May 24, 2019

Uh oh!

dylad commented May 24, 2019

Uh oh!

maribu commented May 24, 2019

Uh oh!

dylad commented Jun 5, 2019

Uh oh!

MrKevinWeiss commented Jun 6, 2019

Uh oh!

dylad commented Jun 6, 2019

Uh oh!

maribu commented Jun 6, 2019

Uh oh!

dylad commented Jun 6, 2019

Uh oh!

dylad commented Jun 19, 2019

Uh oh!

MrKevinWeiss commented Jun 19, 2019

Uh oh!

maribu commented Jun 19, 2019

Uh oh!

dylad commented Jun 19, 2019

Uh oh!

MrKevinWeiss commented Jun 20, 2019

Uh oh!

MrKevinWeiss commented Jun 20, 2019

Uh oh!

dylad commented Jun 20, 2019

Uh oh!

benemorius commented Jun 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maribu commented Jun 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fjmolinas left a comment

Choose a reason for hiding this comment

Uh oh!

kaspar030 commented Sep 9, 2019

Uh oh!

maribu commented Sep 9, 2019

Uh oh!

OYTIS commented Sep 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kaspar030 commented Sep 9, 2019

Uh oh!

maribu commented Sep 9, 2019

Uh oh!

benpicco commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maribu commented Sep 14, 2019

Uh oh!

maribu commented Sep 14, 2019

Uh oh!

maribu commented Sep 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

maribu commented Apr 10, 2019 •

edited by dylad

Loading

benemorius commented Jun 20, 2019 •

edited

Loading

maribu commented Jun 20, 2019 •

edited

Loading

OYTIS commented Sep 9, 2019 •

edited

Loading

benpicco commented Sep 13, 2019 •

edited

Loading