tests/gnrc_udp: Replace atoi() by strtol().#11356
Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom Apr 11, 2019
Merged
Conversation
jcarrano
added
Type: bug
miri64
requested changes
Apr 8, 2019
Member
miri64
left a comment
miri64
left a comment
There was a problem hiding this comment.
Weird error handling, but apparently it is the only way with that function.
However, please only use goto if there is no other elegant way. Jumping into the middle of the function is not at all elegant ;-).
tests/gnrc_udp/udp.c
Outdated
| if (argc > 5) { | ||
| num = strtol(argv[5], &conversion_end, 0); | ||
| if (*conversion_end != '\0') { | ||
| goto send_syntax_err; |
Member
There was a problem hiding this comment.
Rather use a _usage() function here and just return 1. Jumping into the middle of some if-handling just invites spaghetti code.
miri64
requested changes
Apr 9, 2019
| data_len = atoi(data_len_str); | ||
| if (data_len == 0) { | ||
| data_len = strtoul(data_len_str, &conversion_end, 0); | ||
| if (*conversion_end != '\0') { |
Member
There was a problem hiding this comment.
Sleeping over it, let's just focus on fixing this one for now for the release. The other stuff should also be fixed in applications like examples/gnrc_networking
Member
|
Ping @jcarrano? |
jcarrano
force-pushed
the
fix_udp_atoi-master
branch
from
b860a31 to
54cbdaa
Compare
Contributor
Author
|
@miri64 I stripped down the patch. |
This patch is a reduced version of an earlier one, with the bare minimum required to be able to run the test and get the release going. Original description: atoi() cannot detect errors. Many implementation return zero on error and that is what was being checked here, making the "udp send" command unable to parse integer values of zero. On top of this, the behavior on errors does not seem to be specified in the standard (so it is not even correct to check for zero even when zero is not an accepted value, like for a port number). The result of all this is that sending UDP packets of zero length (as required by the Release Specs) was not possible. This patch replaces atoi by strlen, which allows for robust error detection. Sending zero length packets is possible.
Member
|
Murdocks complaining about an unrelated error here Line 62 in e0de94c |
This was causing the CI build to fail in the static-check stage (cppcheck).
Member
|
Please adapt your backport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
atoi() cannot detect errors. Many implementation return zero on error and that is what was being checked here, making the "udp send" command unable to parse integer values of zero. On top of this, the behavior on errors does not seem to be specified in the standard (so it is not even correct to check for zero even when zero is not an accepted value, like for a port number).
The result of all this is that sending UDP packets of zero length (as required by the Release Specs) was not possible.
This patch replaces atoi by strlen, which allows for robust error detection. Sending zero length packets is possible.
Testing procedure
Run
make -C tests/gnrc_udp all termIn the RIOT terminal, try to send a 0 length packet:
With this patch:
Issues/PRs references
None.