drivers/encx24j600: Allow empty iolist elements#11325
Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom Apr 1, 2019
Merged
drivers/encx24j600: Allow empty iolist elements#11325kaspar030 merged 1 commit intoRIOT-OS:masterfrom
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
Conversation
maribu
added
Type: bug
kaspar030
reviewed
Apr 1, 2019
drivers/encx24j600/encx24j600.c
Outdated
| } else { | ||
| in = ptr; | ||
| } | ||
| if (len) { |
Contributor
There was a problem hiding this comment.
style nit: why not
if (!len) {
return;
}
Member
Author
There was a problem hiding this comment.
Done. (Due to the simplicity of this PR, I just squashed right away.)
24 tasks
This commits allows using netdev_driver_t::send() to be called with one or more empty iolist elements. This fixes issue RIOT-OS#11163
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This commits allows using netdev_driver_t::send() to be called with one or more empty iolist elements. This f1x3s issue #11163
Testing procedure
See #11163
Issues/PRs references
F1x3s #11163
(leet-speak used to prevent auto-close)