mrf24j40: don't load data if iol->iol_len == 0#11321
Merged
MichelRottleuthner merged 1 commit intoRIOT-OS:masterfrom Apr 1, 2019
Merged
mrf24j40: don't load data if iol->iol_len == 0#11321MichelRottleuthner merged 1 commit intoRIOT-OS:masterfrom
MichelRottleuthner merged 1 commit intoRIOT-OS:masterfrom
Conversation
bergzand
added
Type: bug
24 tasks
miri64
previously requested changes
Apr 1, 2019
Member
miri64
left a comment
miri64
left a comment
There was a problem hiding this comment.
Code-wise you have my ACK. Don't have the hardware to test though.
miri64
dismissed
their stale review
Oops, I did not intent to do a change request...
Member
|
@MichelRottleuthner @PeterKietzmann can maybe someone of you test? |
MichelRottleuthner
approved these changes
Apr 1, 2019
Contributor
MichelRottleuthner
left a comment
MichelRottleuthner
left a comment
There was a problem hiding this comment.
Tested with MRF24J40MA on nucleo-l476rg. Crashes on master and works with this PR. Code looks valid and was already approved by @miri64 -> ACK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
mrf24j40 version of the
iol->iol_len==0issue described in #11163Testing procedure
See #11163
Issues/PRs references
#11163