ble/nimble: add support for built-in IPSS service#11296
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Jun 4, 2019
Merged
ble/nimble: add support for built-in IPSS service#11296miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64 merged 1 commit intoRIOT-OS:masterfrom
Conversation
haukepetersen
added
Type: new feature
haukepetersen
force-pushed
the
add_nimble_ipsp
branch
from
dc1d3ec to
6ce42e6
Compare
Contributor
Author
|
updated this PR by rebasing it on the current state of #11273 |
haukepetersen
force-pushed
the
add_nimble_ipsp
branch
from
6ce42e6 to
42a416e
Compare
haukepetersen
added
CI: ready for build
Contributor
Author
|
deps are merged, rebased once again. |
|
Maybe I am doing something wrong, but I don't see a service called |
Contributor
Author
|
yes, you are right. Something went wrong when merging this functionality into NimBLE, will look into it. |
haukepetersen
force-pushed
the
add_nimble_ipsp
branch
from
42a416e to
fb3feba
Compare
Contributor
Author
|
Nope, I simply flashed the wrong binary... Building and flashing with I also rebased this PR, just in case. |
miri64
approved these changes
Jun 4, 2019
Member
miri64
left a comment
miri64
left a comment
There was a problem hiding this comment.
Tested with nrf52dk and NRFconnect my Moto X4. Works as described. Code is simple and straight forward. ACK.
miri64
added
Reviewed: 1-fundamentals
Contributor
Author
|
thx |
aabadie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Step 1 for enabling IPv6-over-BLE for NimBLE on RIOT. More to follow.
This PR adds support for building the
IPSS(internet protocol support service) for NimBLE. The actual service is implemented in NimBLE upstream, so this PR only adds the corresponding makefiles and auto-init capabilities.Testing procedure
Simply build and flash
examples/nimble_gattwithUSEMODULE=nimble_svc_ipssand scan the device with a scanner of your choice. When doing a GATT service discovery, theInternet Protocol Support Servershould show up.Problem: we have a little hen-and-egg problem, as the service is not yet merged to NimBLE master (see apache/mynewt-nimble#392), and also the NimBLE package in RIOT is not based on that branch. So for testing one hast to manually point the NimBLE package to the mentioned NimBLE branch (for now).
Issues/PRs references
depends on NimBLE upstream PR: apache/mynewt-nimble#392#11273 will bump the NimBLE version in RIOT to pull in the above changes