sys : net : Packet buffer by miri64 · Pull Request #1129 · RIOT-OS/RIOT

miri64 · 2014-05-09T13:55:52Z

~~Based on #1101. Tests will follow~~

This PR adds a priority-based packet buffer datatype for the network stack.

Kijewski · 2014-05-09T14:04:06Z

Makefile.dep

The inner check is not needed anymore.

miri64 · 2014-05-27T10:59:09Z

No longer WIP.

miri64 · 2014-05-27T16:06:21Z

@Kijewski, @OlegHahm, @haukepetersen could you review please.

Kijewski · 2014-05-27T16:59:39Z

sys/net/crosslayer/packetbuf/Makefile

Sorry copy-pasta from somewhere :/

What's wrong with that?

It's not wrong, but kinda superfluous.

It makes renaming the module easier...

This could be removed now.

LudwigKnuepfer · 2014-06-02T08:43:14Z

Can you fill out the description so one can figure out what the PR does, please?

miri64 · 2014-06-02T12:38:40Z

Done

thomaseichinger · 2014-06-16T07:49:38Z

sys/net/crosslayer/packetbuf/packetbuf.c

miri64 · 2014-06-16T08:15:34Z

Rebased and addressed comments.

OlegHahm · 2014-06-22T19:08:27Z

sys/net/include/packetbuf.h

Are 32 bit necessary here?

Yes, because of https://github.com/RIOT-OS/RIOT/blob/master/core/include/queue.h#L41

OlegHahm · 2014-06-22T19:16:34Z

How about an enum for the flags?

OlegHahm · 2014-06-22T19:20:05Z

sys/net/crosslayer/packetbuf/packetbuf.c

I think additional parens would improve readability.

Kijewski reviewed May 9, 2014
View reviewed changes

Makefile.dep Outdated

Copy link
Copy Markdown

Contributor

Kijewski May 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inner check is not needed anymore.

miri64 added WIP labels May 9, 2014

miri64 added this to the Release NEXT MAJOR milestone May 9, 2014

miri64 assigned Kijewski May 9, 2014

miri64 removed the WIP label May 27, 2014

miri64 assigned OlegHahm and unassigned Kijewski May 27, 2014

Kijewski reviewed May 27, 2014
View reviewed changes

miri64 changed the title ~~Packet buffer~~ sys : net : Packet buffer Jun 2, 2014

miri64 mentioned this pull request Jun 3, 2014

Use packet buffer in IPv6 #1264

Closed

thomaseichinger reviewed Jun 16, 2014
View reviewed changes

sys/net/crosslayer/packetbuf/packetbuf.c Outdated

Copy link
Copy Markdown

Member

thomaseichinger Jun 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2.1

OlegHahm reviewed Jun 22, 2014
View reviewed changes

sys/net/crosslayer/packetbuf/packetbuf.c

Copy link
Copy Markdown

Member

OlegHahm Jun 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think additional parens would improve readability.

Conversation

miri64 commented May 9, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

miri64 commented May 27, 2014

Uh oh!

miri64 commented May 27, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LudwigKnuepfer commented Jun 2, 2014

Uh oh!

miri64 commented Jun 2, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

miri64 commented Jun 16, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OlegHahm commented Jun 22, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants