boards/esp32: adds Heltec WiFi LoRa 32 V2 board definition by gschorcht · Pull Request #11265 · RIOT-OS/RIOT

gschorcht · 2019-03-25T16:12:28Z

Contribution description

This PR adds the board definition for Heltec WiFi LoRa 32 V2 board. Heltec WiFi LoRa 32 V2 is an ESP32 development board with 8 MB Flash that uses the EPS32 chip directly. It integrates

a SemTech SX1276 or SX1278 for LoRaWAN communication and
a SSD1306 128x64 OLED display connected via I2C.

Many GPIOs are broken out. Since the board is open source hardware, a number of clones are available.

Testing procedure

Application examples/lorawan can be used to test the board including the LoRaWAN functionality.

DRIVER=sx127x make BOARD=esp32-heltec-lora32-v2 -C examples/lorawan/ flash

Issues/PRs references

Depends on PR #13685

aabadie · 2019-03-25T16:43:47Z

boards/esp32-heltec-lora32-v2/Makefile.dep

@@ -0,0 +1 @@
+include $(RIOTBOARD)/common/esp32/Makefile.dep


Here you could also add (maybe it has other implication with esp stuff ?):

ifneq (,$(filter netdev_default,$(USEMODULE))) USEMODULE += sx1276 endif

Hm, ..., not sure what the most usual case is. Default network interface might be also esp_now or esp_wifi.

Why is it either or?
With this you'd get both sx1276 and esp_now.

But this can be added when #12994 is merged so the user doesn't have to be careful not to forget to adding GNRC_NETIF_NUMOF=2, or else run into an assert failure when the pre-allocated netif slots run out.

boards/esp32-heltec-lora32-v2/doc.txt

gschorcht · 2019-04-15T12:19:10Z

@yegorich Squased.

boards/esp32-heltec-lora32-v2/doc.txt

MrKevinWeiss · 2019-06-13T12:28:45Z

release status ping, should I change the milestone?

gschorcht · 2019-06-17T07:07:25Z

@MrKevinWeiss Sorry for late answer, I'm quite busy at the moment. From my point of view, it is ready for release. I'm just waiting for a trigger to squash it.

gschorcht · 2019-06-17T07:08:03Z

@MrKevinWeiss Sorry for late answer, I'm quite busy at the moment. From my point of view, it is ready for release. I'm just waiting for a trigger to squash it.

MrKevinWeiss · 2019-06-25T16:50:23Z

Does anyone else have this board? If not I can add it to the wishlist but then I don't think it will get in to this release. Please advise otherwise I will move the milestone.

MrKevinWeiss · 2019-06-29T06:57:21Z

I think we can wait until next release for this one.

fjmolinas · 2020-01-03T19:37:55Z

@gschorcht if you can run compile_and_test_for_board and post the output it would be enough to move forward with this one.

boards/esp32-heltec-lora32-v2/doc.txt

yegorich · 2020-02-20T09:49:14Z

@gschorcht I think, the only thing missing is board_init() in board.h.

gschorcht · 2020-02-20T11:18:21Z

@gschorcht I think, the only thing missing is board_init() in board.h.

Yes, it will become a problem once I rebased it.

gschorcht · 2020-02-21T07:49:16Z

With the last commit, I added a small section on how to use the board's display.

gschorcht · 2020-03-17T16:53:39Z

May I squash this PR?

benpicco · 2020-03-23T14:28:37Z

More than a month has passed, I'd say it's safe to squash 😉

gschorcht · 2020-03-24T05:34:14Z

Squashed. But I have removed the USEMODULE += boards_common_esp32 from Makefile.dep. It will be pulled in by boards/common/esp32/Makefile.dep once PR #13685 is merged. We should wait for this cleanup.

Another question remains. @aabadie suggested to use sx1276 as netdev default.

ifneq (,$(filter netdev_default,$(USEMODULE)))
  USEMODULE += sx1276
endif

This would mean that it would pull in esp_now and sx1276. Would this be OK?

boards/esp32-heltec-lora32-v2/include/periph_conf.h

benpicco · 2020-03-24T13:18:25Z

You can squash again 😉

fixup! boards/esp32: Heltec WiFi LoRa 32 V2 board added fixup! boards/esp32: Heltec WiFi LoRa 32 V2 board added

benpicco

Just contains definitions for common code, very straightforward.

Enabling the sx1276 radio can be done when having more than one network interface enabled by default doesn't require additional user configuration.

gschorcht · 2020-03-25T10:34:43Z

@benpico Thanks for reviewing and merging.

aabadie added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: LoRa Area: LoRa radio support Area: boards Area: Board ports labels Mar 25, 2019

aabadie reviewed Mar 25, 2019

View reviewed changes

yegorich reviewed Mar 25, 2019

View reviewed changes

boards/esp32-heltec-lora32-v2/doc.txt Outdated Show resolved Hide resolved

gschorcht force-pushed the boards/esp32-heltec-lora32 branch from 071b31e to d793b7a Compare April 15, 2019 12:18

yegorich reviewed Apr 17, 2019

View reviewed changes

boards/esp32-heltec-lora32-v2/doc.txt Outdated Show resolved Hide resolved

gschorcht force-pushed the boards/esp32-heltec-lora32 branch from d793b7a to 203c936 Compare April 27, 2019 11:29

gschorcht mentioned this pull request Apr 27, 2019

cpu/esp: fix computation of coprocessor save area pointer in initial thread context #11461

Merged

MrKevinWeiss added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable labels Jun 17, 2019

gschorcht mentioned this pull request Jun 26, 2019

boards/esp32: add TTGO T-Beam board definition #11418

Merged

MrKevinWeiss added this to the Release 2019.10 milestone Jun 29, 2019

kb2ma modified the milestones: Release 2019.10, Release 2020.01 Oct 9, 2019

fjmolinas modified the milestones: Release 2020.01, Release 2020.04 Jan 16, 2020

yegorich reviewed Feb 17, 2020

View reviewed changes

boards/esp32-heltec-lora32-v2/doc.txt Show resolved Hide resolved

gschorcht requested a review from fjmolinas as a code owner February 20, 2020 08:10

gschorcht force-pushed the boards/esp32-heltec-lora32 branch from 492e49c to 18e8b6b Compare February 20, 2020 16:38

gschorcht added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 21, 2020

gschorcht requested review from PeterKietzmann, cgundogan, haukepetersen and miri64 as code owners March 8, 2020 13:59

gschorcht force-pushed the boards/esp32-heltec-lora32 branch from ee9ec06 to 79c8f43 Compare March 9, 2020 06:10

This was referenced Mar 9, 2020

tests: fix netopt_state_t value handling in driver_sx127x #13596

Merged

drivers/sx127x: changes in DIO handling #13604

Merged

gschorcht force-pushed the boards/esp32-heltec-lora32 branch from 79c8f43 to b67c330 Compare March 23, 2020 15:54

gschorcht force-pushed the boards/esp32-heltec-lora32 branch from b67c330 to 7ae4248 Compare March 23, 2020 16:58

gschorcht added the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 24, 2020

gschorcht force-pushed the boards/esp32-heltec-lora32 branch 2 times, most recently from b0cf48b to 948c45d Compare March 24, 2020 10:48

benpicco removed the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 24, 2020

benpicco reviewed Mar 24, 2020

View reviewed changes

boards/esp32-heltec-lora32-v2/include/periph_conf.h Outdated Show resolved Hide resolved

boards/esp32: Heltec WiFi LoRa 32 V2 board added

b16ff57

fixup! boards/esp32: Heltec WiFi LoRa 32 V2 board added fixup! boards/esp32: Heltec WiFi LoRa 32 V2 board added

gschorcht force-pushed the boards/esp32-heltec-lora32 branch from a88f4e9 to b16ff57 Compare March 24, 2020 13:23

benpicco approved these changes Mar 24, 2020

View reviewed changes

benpicco merged commit 9d4f7fb into RIOT-OS:master Mar 25, 2020

gschorcht deleted the boards/esp32-heltec-lora32 branch March 25, 2020 10:34

benpicco mentioned this pull request Mar 26, 2020

boards/esp32-heltec-lora32-v2: enable sx1276 by default #13727

Merged

gschorcht mentioned this pull request Mar 29, 2020

boards: define the interrupt flank for BTN0 for ESP32 Heltec Lora32 V2 #13747

Merged

Conversation

gschorcht commented Mar 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution description

Testing procedure

Issues/PRs references

Uh oh!

aabadie Mar 25, 2019

Choose a reason for hiding this comment

Uh oh!

gschorcht Mar 25, 2019

Choose a reason for hiding this comment

Uh oh!

benpicco Mar 24, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gschorcht commented Apr 15, 2019

Uh oh!

Uh oh!

MrKevinWeiss commented Jun 13, 2019

Uh oh!

gschorcht commented Jun 17, 2019

Uh oh!

gschorcht commented Jun 17, 2019

Uh oh!

MrKevinWeiss commented Jun 25, 2019

Uh oh!

MrKevinWeiss commented Jun 29, 2019

Uh oh!

fjmolinas commented Jan 3, 2020

Uh oh!

Uh oh!

yegorich commented Feb 20, 2020

Uh oh!

gschorcht commented Feb 20, 2020

Uh oh!

gschorcht commented Feb 21, 2020

Uh oh!

gschorcht commented Mar 17, 2020

Uh oh!

benpicco commented Mar 23, 2020

Uh oh!

gschorcht commented Mar 24, 2020

Uh oh!

Uh oh!

benpicco commented Mar 24, 2020

Uh oh!

benpicco left a comment

Choose a reason for hiding this comment

Uh oh!

gschorcht commented Mar 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gschorcht commented Mar 25, 2019 •

edited

Loading