Skip to content

cpu/saml1x: set wait state according to datasheet#11249

Merged
emmanuelsearch merged 1 commit intoRIOT-OS:masterfrom
dylad:pr/saml1x_waitstate
Mar 24, 2019
Merged

cpu/saml1x: set wait state according to datasheet#11249
emmanuelsearch merged 1 commit intoRIOT-OS:masterfrom
dylad:pr/saml1x_waitstate

Conversation

@dylad
Copy link
Copy Markdown
Member

@dylad dylad commented Mar 23, 2019

Contribution description

According to datasheet, SAML1X should be set in PL2 with 1 WaitState if it runs at 16MHz (which is currently the default speed supported).
See Chap 46.12 from the datasheet

Testing procedure

run any tests you want on SAML10-XPRO or SAML11-XPRO

Issues/PRs references

@emmanuelsearch could you check that your PR works with this one ?

@dylad dylad added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: cpu Area: CPU/MCU ports labels Mar 23, 2019
@dylad dylad added this to the Release 2019.04 milestone Mar 23, 2019
@dylad dylad requested review from aabadie and emmanuelsearch March 23, 2019 20:41
@emmanuelsearch
Copy link
Copy Markdown
Member

emmanuelsearch commented Mar 23, 2019 •
edited
Loading

@dylad I tried tests/riotboot with this and #11248 on SAML11-xpro. It does not get through the jump from the bootloader into the image (tried LED debugging, could not trace it precisely, but it seems it does not make it to kernel_init)

@dylad dylad force-pushed the pr/saml1x_waitstate branch from f4550f7 to 82aa6c0 Compare March 24, 2019 09:44
@dylad
Copy link
Copy Markdown
Member Author

dylad commented Mar 24, 2019

@emmanuelsearch Should be better now.
I forced-push to squash at the same time.

@emmanuelsearch
Copy link
Copy Markdown
Member

emmanuelsearch commented Mar 24, 2019

with this, riotboot support (with #11248) works like a charm on saml11xpro!

@emmanuelsearch emmanuelsearch added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 24, 2019
@emmanuelsearch emmanuelsearch mentioned this pull request Mar 24, 2019
Merged
@dylad
Copy link
Copy Markdown
Member Author

dylad commented Mar 24, 2019

@emmanuelsearch Care to ACK ?

@emmanuelsearch emmanuelsearch merged commit 1859d03 into RIOT-OS:master Mar 24, 2019
@dylad dylad deleted the pr/saml1x_waitstate branch June 18, 2019 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmanuelsearch emmanuelsearch emmanuelsearch approved these changes

@aabadie aabadie Awaiting requested review from aabadie

Assignees

No one assigned

Labels

Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2019.04

Development

Successfully merging this pull request may close these issues.

2 participants

@dylad @emmanuelsearch