Merged
Conversation
5 tasks
cladmi
added
the
State: waiting for other PR
emmanuelsearch
removed
the
State: waiting for other PR
Member
Author
|
@dylad can you check if this works on saml10-xpro too? |
Member
|
@emmanuelsearch I'll check on both boards. Could you rebase please ? |
emmanuelsearch
force-pushed
the
pr-riotboot-saml1x
branch
from
4ec41b1 to
d1287a8
Compare
Member
Author
|
@dylad rebased |
dylad
reviewed
Mar 25, 2019
Member
dylad
left a comment
dylad
left a comment
There was a problem hiding this comment.
two nitpicks, you can squash at the same time !
Sorry I should have checked that sooner...
cpu/cortexm_common/include/cpu.h
Outdated
| } | ||
|
|
||
| /* The following register is only present for Cortex-M0+, -M3, -M4 and -M7 CPUs */ | ||
| /* The following register is only present for Cortex-M0+, -M3, -M4, -M7 and -M23 CPUs */ |
| # Put other features on these boards (in alphabetical order) | ||
| FEATURES_PROVIDED += riotboot | ||
|
|
||
|
|
dylad
added
Type: new feature
emmanuelsearch
force-pushed
the
pr-riotboot-saml1x
branch
from
d1287a8 to
cc07123
Compare
Member
Author
|
@dylad done. |
dylad
approved these changes
Mar 26, 2019
Member
dylad
left a comment
dylad
left a comment
There was a problem hiding this comment.
ACK.
tested work on SAML10-XPRO and SAML11-XPRO.
dylad
added
the
CI: ready for build
Member
|
@emmanuelsearch |
cladmi
approved these changes
Mar 26, 2019
Contributor
cladmi
left a comment
cladmi
left a comment
There was a problem hiding this comment.
I successfully tested this PR with saml11-xpro used in combination with #11172 for the different riotboot/flash-slot1, riotboot/flash-slot0, riotboot/flash-extended-slot0, targets.
Only need to address the static-test remarks.
emmanuelsearch
force-pushed
the
pr-riotboot-saml1x
branch
from
cc07123 to
61c793a
Compare
Member
Author
Member
|
All green -> here we go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds riotboot support for the SAML10-xpro and SAML11-xpro boards.
Testing procedure
if tests/riotboot works, we're fine ;)
Issues/PRs references
needs #11249 to work (additional clock initialization patch in cpu/saml1x/cpu.c )