Skip to content

drivers/enc28j60: Allow sending with empty chunks#11214

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
maribu:enc28j60
Mar 30, 2019
Merged

drivers/enc28j60: Allow sending with empty chunks#11214
miri64 merged 1 commit intoRIOT-OS:masterfrom
maribu:enc28j60

Conversation

@maribu
Copy link
Copy Markdown
Member

@maribu maribu commented Mar 20, 2019 •
edited by miri64
Loading

Contribution description

This commit allows netdev_driver_t::send() of enc28j60 to be passed an iolist_t containing one or more empty elements.

Testing procedure

Run examples/gnrc_networking and try if udp send ff02::1 1337 "" works now. It shouldn't with master. Also check if ping6 to make sure no regression is introduces.

Issues/PRs references

Fix of #11163 for the enc28j60.

@maribu
drivers/enc28j60: Allow sending with empty chunks
f5cd25b 
This commit allows `netdev_driver_t::send()` of `enc28j60` to be passed an
`iolist_t` containing one or more empty elements.
@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 20, 2019
@maribu maribu requested review from miri64 and smlng March 20, 2019 09:03
@maribu
Copy link
Copy Markdown
Member Author

maribu commented Mar 29, 2019

Maybe @gschorcht can have a look?

@gschorcht
Copy link
Copy Markdown
Contributor

gschorcht commented Mar 29, 2019 •
edited
Loading

Code look's ok for me and it seems to be reasonable. I will test it later today.

@gschorcht gschorcht added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines labels Mar 29, 2019
@gschorcht
Copy link
Copy Markdown
Contributor

gschorcht commented Mar 30, 2019

@maribu Tested. It works as expected but it was also working with current master. At least it did not crash. The only difference I can observe with wireshark is that with current master there are two additional UDP paylod bytes bf 03 even though the UDP payload should be empty. I guess, it is garbage.

@gschorcht gschorcht added the Reviewed: 3-testing The PR was tested according to the maintainer guidelines label Mar 30, 2019
gschorcht
gschorcht approved these changes Mar 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@gschorcht gschorcht left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK from my side.

@miri64 miri64 mentioned this pull request Mar 30, 2019
Closed
24 tasks
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 30, 2019
@miri64
Copy link
Copy Markdown
Member

miri64 commented Mar 30, 2019

I allowed myself to reword a sentence in OP to not auto-close #11163 ;-)

@miri64 miri64 merged commit 85276fb into RIOT-OS:master Mar 30, 2019
@maribu maribu deleted the enc28j60 branch March 30, 2019 17:16
@danpetry danpetry added this to the Release 2019.04 milestone Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gschorcht gschorcht gschorcht approved these changes

@miri64 miri64 Awaiting requested review from miri64

@smlng smlng Awaiting requested review from smlng

Assignees

No one assigned

Labels

Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2019.04

Development

Successfully merging this pull request may close these issues.

4 participants

@maribu @gschorcht @miri64 @danpetry