Skip to content

make: buildtest with "-Wall -Wextra -Werror"#1121

Closed
Kijewski wants to merge 1 commit intoRIOT-OS:masterfrom
Kijewski:buildtest-werror
Closed

make: buildtest with "-Wall -Wextra -Werror"#1121
Kijewski wants to merge 1 commit intoRIOT-OS:masterfrom
Kijewski:buildtest-werror

Conversation

@Kijewski
Copy link
Copy Markdown
Contributor

@Kijewski Kijewski commented May 7, 2014

DO NOT MERGE UNTIL ALL WARNINGS ARE FIXED IN MASTER

With almost all warnings fixed or at least being addressed in an open PR, I think we should strive to keep it that way.

This PR makes buildtest more pedantic by supplying -Wall -Wexta -Werror by default.
This can be disabled through make W_ALL=0 W_EXTRA=0 W_ERROR=0, resp., or with make W_NONE=1, which disables every extra flag.
With make PEDANTIC=1 PEDANTIC_ERRORS=1 you can make the buildtest even more pedantic.

Also the generic make variable W_FLAGS is added, through which extra CFLAGS can be supplied in the normal make all.

For non-buildtest builds you can supply W_NONE=0 and/or the individual flags,
too

@Kijewski Kijewski added the make label May 7, 2014
@Kijewski Kijewski added this to the Release NEXT MAJOR milestone May 7, 2014
@Kijewski Kijewski mentioned this pull request May 15, 2014
Closed
@OlegHahm OlegHahm assigned LudwigKnuepfer and unassigned OlegHahm May 15, 2014
@Kijewski Kijewski added the WIP label May 24, 2014
@mehlis
Copy link
Copy Markdown
Contributor

mehlis commented May 30, 2014

+1 to have this PR merged until next release (make it a release goal)

@OlegHahm OlegHahm removed this from the Release NEXT MAJOR milestone Jun 3, 2014
@Kijewski Kijewski added the tests label Jun 7, 2014
@Kijewski Kijewski added this to the Release NEXT MAJOR milestone Jun 7, 2014
@LudwigKnuepfer
Copy link
Copy Markdown
Member

LudwigKnuepfer commented Aug 1, 2014

Please rebase

@Kijewski
Copy link
Copy Markdown
Contributor Author

Kijewski commented Aug 1, 2014

Rebased.

@LudwigKnuepfer
Copy link
Copy Markdown
Member

LudwigKnuepfer commented Sep 6, 2014

Please rebase.

@Kijewski
Copy link
Copy Markdown
Contributor Author

Kijewski commented Sep 6, 2014

Rebased.

1 similar comment
@Kijewski
Copy link
Copy Markdown
Contributor Author

Kijewski commented Oct 28, 2014

Rebased.

@OlegHahm OlegHahm modified the milestones: Release NEXT MAJOR, Release 2014.12 Dec 1, 2014
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Dec 1, 2014

I don't think we can achieve this for the upcoming release already. Postponed.

@OlegHahm OlegHahm force-pushed the master branch 3 times, most recently from 9f184dd to 45554bf Compare March 31, 2015 13:01
@miri64
Copy link
Copy Markdown
Member

miri64 commented Mar 31, 2015

How's the status on this front?

@LudwigKnuepfer
Copy link
Copy Markdown
Member

LudwigKnuepfer commented Mar 31, 2015

Master still has issues.

@miri64
Copy link
Copy Markdown
Member

miri64 commented May 26, 2015

Closed as memo for now. Reopen if you object.

@miri64 miri64 closed this May 26, 2015
@miri64 miri64 added the State: archived State: The PR has been archived for possible future re-adaptation label May 26, 2015
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented May 26, 2015

What's the reason for closing?

@jnohlgard
Copy link
Copy Markdown
Member

jnohlgard commented May 26, 2015

I would like to see the CI build without warnings as a long term goal.

@jnohlgard jnohlgard reopened this May 26, 2015
@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 24, 2017

(fails already for the new power management T.T)

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 24, 2017

=> postponed I guess.

@miri64 miri64 modified the milestones: Release 2017.04, Release 2017.01 Jan 24, 2017
@kYc0o kYc0o mentioned this pull request Jan 25, 2017
Closed
7 tasks
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Jan 25, 2017 •
edited
Loading

Not sure this is so easy, since the build fails after the first warning - which happens rather early on most platforms except native.

Well it is easy, just tedious ;-)

And how would you do it?

@kYc0o kYc0o mentioned this pull request Feb 3, 2017
Closed
@miri64
Copy link
Copy Markdown
Member

miri64 commented Apr 5, 2017

And how would you do it?

Same way we did cppcheck?

@miri64
Copy link
Copy Markdown
Member

miri64 commented May 10, 2017

So should we tackle this for 2017.07?

@Kijewski
Copy link
Copy Markdown
Contributor Author

Kijewski commented May 10, 2017 •
edited
Loading

So should we tackle this for 2017.07?

How about CFLAGS += -Wall -Wextra -Werror in ./{core,sys,drivers}/Makefile? Might be a better approach than my PR, as it "allows" the user to continue writing ugly application code. Also we could tackle one directory after another without having to fix everything at once.

@jnohlgard
Copy link
Copy Markdown
Member

jnohlgard commented May 10, 2017 •
edited
Loading

@Kijewski

How about CFLAGS += -Wall -Wextra -Werror in ./{core,sys,drivers}/Makefile?

... and in boards/ and cpu/

@miri64 miri64 mentioned this pull request Jun 8, 2017
Merged
@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Jun 21, 2017

A good candidate for 2017.07? @miri64 @Kijewski ?

Needs rebase btw

@miri64
Copy link
Copy Markdown
Member

miri64 commented Oct 5, 2017

Conventional pre-release ping. ;-)

This was referenced Oct 26, 2017
Merged
Closed
@smlng smlng mentioned this pull request Oct 31, 2017
Merged
@smlng
Copy link
Copy Markdown
Member

smlng commented Oct 31, 2017

I suggest to close as memo as it is not mergeable anymore and use #7919 as a replacement.

@Kijewski Kijewski added State: archived State: The PR has been archived for possible future re-adaptation and removed State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Nov 1, 2017
@Kijewski
Copy link
Copy Markdown
Contributor Author

Kijewski commented Nov 1, 2017

Closed as memo because the original author is lazy.

@Kijewski Kijewski closed this Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@LudwigKnuepfer LudwigKnuepfer

Labels

Area: build system Area: Build system Area: tests Area: tests and testing framework State: archived State: The PR has been archived for possible future re-adaptation

Projects

None yet

Milestone

Release 2017.10

Development

Successfully merging this pull request may close these issues.