Skip to content

cpu/nrf5x/nrfmin: ignore empty iolist elements#11194

Closed
haukepetersen wants to merge 1 commit intoRIOT-OS:masterfrom
haukepetersen:fix_nrfmin_zerolengthiofield
Closed

cpu/nrf5x/nrfmin: ignore empty iolist elements#11194
haukepetersen wants to merge 1 commit intoRIOT-OS:masterfrom
haukepetersen:fix_nrfmin_zerolengthiofield

Conversation

@haukepetersen
Copy link
Copy Markdown
Contributor

Contribution description

fixes #11163 for the nrfmin radio driver

Testing procedure

e.g. run examples/gnrc_networking enabling the nrfmin module (USEMODULE=nrfmin) on 2 Nordic boards. Sending empty UDP payloads should not lead to crashes.

Issues/PRs references

#11163

@haukepetersen haukepetersen added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 15, 2019
@ghost ghost self-requested a review March 17, 2019 09:17
@ghost
Copy link
Copy Markdown

ghost commented Mar 22, 2019

I can send and receive packets with payload size of zero on master (gnrc_networking+udp).
However, with this PR I can still send packets with 0 payload, but I am not receiving these packets. Reception of packets with some payload still works. I think this is a step backwards.?

@haukepetersen
Copy link
Copy Markdown
Contributor Author

it should be the other way around, ideed... Will have another look

@miri64
Copy link
Copy Markdown
Member

miri64 commented Apr 2, 2019

This one is the only one remaining in #11163. I try to test this tomorrow. Or did you figure out what went wrong @SemjonKerner?

@ghost
Copy link
Copy Markdown

ghost commented Apr 2, 2019

Please try it. I was not in office last week and will not come in before thursday, so I could not verify my findings. In the worst case I messed up with github and in the best case the master is already fit for #11163.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Apr 3, 2019

I can confirm @SemjonKerner's findings, that in master sending 0 bytes is possible, but with this PR it is not (I even checked the debug output in the driver; the packet does not arrive there). As to why this is: This PR is based on a version of master before #11161 was merged, which only allowed GNRC to handle payload length 0 packets in the first place (as pointed out in #11163). Considering that #11163 is not an issue for nrfmin in master, I rather close this PR as it adds unnecessary code.

@miri64 miri64 closed this Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: drivers Area: Device drivers Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

netdev: iolist not checked for empty elements on send

2 participants