cpu/esp_common: esp_now doesn't call memcpy if iol_len is 0#11187
Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom Apr 2, 2019
Merged
cpu/esp_common: esp_now doesn't call memcpy if iol_len is 0#11187miri64 merged 2 commits intoRIOT-OS:masterfrom
miri64 merged 2 commits intoRIOT-OS:masterfrom
Conversation
gschorcht
added
Area: network
24 tasks
miri64
reviewed
Mar 15, 2019
miri64
added
Reviewed: 1-fundamentals
Member
|
LGTM, but can not test. |
Contributor
Author
|
@miri64 Added the proposed NULL pointer check to this PR. I hope it's ok, otherwise I would have to prepare a separate PR for a single line. |
miri64
reviewed
Mar 30, 2019
Member
|
Looks even better. Still don't have the hardware to test :( |
miri64
reviewed
Mar 30, 2019
Member
|
I'm fine with the fixups. You may squash. I'll try to get some hardware from my colleagues next week / try to convince them to test. |
gschorcht
force-pushed
the
cpu/esp_common/esp_now/iol_len
branch
from
45faf34 to
9cc3913
Compare
Contributor
Author
|
@miri Squashed. Thanks for reviewing. |
miri64
approved these changes
Apr 2, 2019
Member
miri64
left a comment
miri64
left a comment
There was a problem hiding this comment.
Can't get my hands on some hardware at the moment. But the code change is simple enough that I don't believe that it will break anything even if merged untested.
miri64
added
the
CI: ready for build
Contributor
Author
|
@miri64 Thanks for reviewing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Fixes the problem described in #11163.
Testing procedure
Tested with the procedure described in #11163
Issues/PRs references
Related to issue #11163