Skip to content

cpu/esp32: esp_eth doesn't call memcpy if iol_len is 0#11186

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
gschorcht:cpu/esp32/esp_eth/iol_len
Apr 2, 2019
Merged

cpu/esp32: esp_eth doesn't call memcpy if iol_len is 0#11186
miri64 merged 1 commit intoRIOT-OS:masterfrom
gschorcht:cpu/esp32/esp_eth/iol_len

Conversation

@gschorcht
Copy link
Copy Markdown
Contributor

@gschorcht gschorcht commented Mar 14, 2019

Contribution description

Fixes the problem described in #11163.

Testing procedure

Tested with the procedure described in #11163

Issues/PRs references

Related to issue #11163

@gschorcht gschorcht added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking Area: drivers Area: Device drivers Platform: ESP Platform: This PR/issue effects ESP-based platforms Area: cpu Area: CPU/MCU ports labels Mar 14, 2019
@gschorcht gschorcht added this to the Release 2019.04 milestone Mar 14, 2019
@miri64 miri64 mentioned this pull request Mar 15, 2019
Closed
24 tasks
@miri64 miri64 added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Mar 15, 2019
miri64
miri64 reviewed Mar 15, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can not test.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 2, 2019
miri64
miri64 approved these changes Apr 2, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't get my hands on some hardware at the moment. But the code change is simple enough that I don't believe that it will break anything even if merged untested.

@miri64 miri64 merged commit 2d906de into RIOT-OS:master Apr 2, 2019
@gschorcht
Copy link
Copy Markdown
Contributor Author

gschorcht commented Apr 2, 2019 •
edited
Loading

@miri64 Thanks for reviewing it.

@gschorcht gschorcht deleted the cpu/esp32/esp_eth/iol_len branch April 2, 2019 16:16
@gschorcht
Copy link
Copy Markdown
Contributor Author

gschorcht commented Apr 2, 2019

@miri64 Thanks for reviewing it.

@gschorcht gschorcht restored the cpu/esp32/esp_eth/iol_len branch April 2, 2019 16:18
@gschorcht gschorcht deleted the cpu/esp32/esp_eth/iol_len branch April 2, 2019 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

No one assigned

Labels

Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2019.04

Development

Successfully merging this pull request may close these issues.

2 participants

@gschorcht @miri64