gnrc_ipv6_nib: check if pkt is NULL on error#11182
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Mar 27, 2019
Merged
Conversation
According to the documentation of `gnrc_ipv6_nib_get_next_hop_l2addr()` `pkt` may be `NULL`. However, whenever that function sends an error message (the methods for that require `orig_pkt` not to be NULL) `pkt` is not checked, which may lead to failed assertions.
miri64
added
Type: bug
miri64
added
CI: needs squashing
cgundogan
approved these changes
Mar 27, 2019
Member
cgundogan
left a comment
cgundogan
left a comment
There was a problem hiding this comment.
Code looks sensible. Fixes the failed assertion in the test application. ACK
cgundogan
added
Reviewed: 1-fundamentals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
According to the documentation of
gnrc_ipv6_nib_get_next_hop_l2addr()pktmay beNULL. However, whenever that function sends an error message (the methods for that requireorig_pktnot to be NULL)pktis not checked, which may lead to failed assertions.Testing procedure
Issues/PRs references
Compile and flash
tests/gnrc_ipv6_nibwithUSEMODULE=gnrc_icmpv6_errorand run the test
Without this fix the test will fail on an assertion at
RIOT/sys/net/gnrc/network_layer/icmpv6/error/gnrc_icmpv6_error.c
Line 244 in 94a10e9
With this fix the tests will pass.
Issues/PRs references
Discovered while debugging #11068 where I use
gnrc_ipv6_nib_get_next_hop_l2addr()withpkt == NULLRIOT/sys/net/gnrc/network_layer/sixlowpan/frag/minfwd/gnrc_sixlowpan_frag_minfwd.c
Lines 51 to 54 in a235f61