netdev/lora: add netdev_lora_rx_info structure for RX info#11144
Merged
aabadie merged 5 commits intoRIOT-OS:masterfrom Mar 8, 2019
Merged
netdev/lora: add netdev_lora_rx_info structure for RX info#11144aabadie merged 5 commits intoRIOT-OS:masterfrom
aabadie merged 5 commits intoRIOT-OS:masterfrom
Conversation
jia200x
added
Type: enhancement
Contributor
|
There is one occurence of |
aabadie
added
the
CI: ready for build
aabadie
approved these changes
Mar 8, 2019
Contributor
aabadie
left a comment
aabadie
left a comment
There was a problem hiding this comment.
I tested all 3 available LoRa applications (I pushed a commit to fix tests/driver_sx127x) and all worked. The changes also make sense.
ACK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds a generic RX info structure for LoRa devices. This obsoletes the
netdev_sx127x_lora_packet_info_tstructure, so MAC layers are not dependent on driver specific headers.Testing procedure
Test documentation with
make doc.Test that
tests/pkg_semtech_loramac,examples/lorawanandtests/drivers_sx127xcompile with no errors.You should be able to see these RX info with
tests/drivers_sx127xIssues/PRs references
Addresses #6797 (comment)
#11022