Skip to content

net/lorawan/hdr: add lorawan header helpers#11143

Merged
smlng merged 3 commits intoRIOT-OS:masterfrom
jia200x:pr/lorawan_hdr
May 6, 2019
Merged

net/lorawan/hdr: add lorawan header helpers#11143
smlng merged 3 commits intoRIOT-OS:masterfrom
jia200x:pr/lorawan_hdr

Conversation

@jia200x
Copy link
Copy Markdown
Member

@jia200x jia200x commented Mar 8, 2019

Contribution description

This PR adds helpers for parsing and building LoRaWAN headers.
It's a part of #11022 and I put it here to make the review easier.

Also, this header is not GNRC LoRaWAN specific but can be used by any stack.

Testing procedure

The commits were taken from #11022. So, they can be seen in action there :)
Alternatively, check the LoRaWAN 1.0.3 specification, chapter 4 (MAC Message format).

Also, test the documentation with make doc.

Issues/PRs references

Part of #11022

@jia200x jia200x added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: LoRa Area: LoRa radio support labels Mar 8, 2019
@jia200x jia200x requested review from aabadie and miri64 March 8, 2019 16:17
Copy link
Copy Markdown
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, some minor stuff

@jia200x
Copy link
Copy Markdown
Member Author

jia200x commented Mar 19, 2019

@aabadie @smlng I think I've addressed all coments

@jia200x
Copy link
Copy Markdown
Member Author

jia200x commented Mar 29, 2019

ping @aabadie @smlng

@smlng smlng added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 29, 2019
@smlng
Copy link
Copy Markdown
Member

smlng commented Mar 29, 2019

please squash

@jia200x
Copy link
Copy Markdown
Member Author

jia200x commented Mar 29, 2019

@smlng done

@smlng
Copy link
Copy Markdown
Member

smlng commented Mar 29, 2019

Ci is not happy with your documentation 😢

@jia200x jia200x force-pushed the pr/lorawan_hdr branch 2 times, most recently from be428e0 to 2ebafe3 Compare April 12, 2019 13:19
@jia200x
Copy link
Copy Markdown
Member Author

jia200x commented Apr 12, 2019

I had to add the net_lorawan group in a .txt file. @smlng @aabadie would you be OK with that?

@smlng smlng added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 6, 2019
@smlng smlng merged commit 3f9a641 into RIOT-OS:master May 6, 2019
@jia200x
Copy link
Copy Markdown
Member Author

jia200x commented May 7, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: LoRa Area: LoRa radio support CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants