Skip to content

gnrc_netif: add NETDEV_TYPE_LORA to L2ADDR check#11136

Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom
jia200x:pr/gnrc_netif_lora
Mar 24, 2019
Merged

gnrc_netif: add NETDEV_TYPE_LORA to L2ADDR check#11136
aabadie merged 1 commit intoRIOT-OS:masterfrom
jia200x:pr/gnrc_netif_lora

Conversation

@jia200x
Copy link
Copy Markdown
Member

@jia200x jia200x commented Mar 7, 2019

Contribution description

This PR adds NETDEV_TYPE_LORA to the L2 address checks in gnrc_netif.
Without this, #11022 crashes on startup.

Testing procedure

Try #11022 without this patch. It will crash during boot.

Issues/PRs references

#11022

@jia200x jia200x requested a review from miri64 March 7, 2019 17:24
@jia200x jia200x mentioned this pull request Mar 7, 2019
Merged
@jia200x jia200x added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: LoRa Area: LoRa radio support Area: network Area: Networking labels Mar 7, 2019
smlng
smlng approved these changes Mar 9, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't see what could go wrong, ACK!

@smlng smlng added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines labels Mar 9, 2019
@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Mar 13, 2019

@smlng green lights

@aabadie aabadie force-pushed the pr/gnrc_netif_lora branch from ff2c5c9 to 83ba971 Compare March 24, 2019 10:11
aabadie
aabadie approved these changes Mar 24, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK and go!

@aabadie aabadie merged commit 1978109 into RIOT-OS:master Mar 24, 2019
@danpetry danpetry added this to the Release 2019.04 milestone Mar 26, 2019
@jia200x jia200x mentioned this pull request Apr 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabadie aabadie aabadie approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

+1 more reviewer

@smlng smlng smlng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: LoRa Area: LoRa radio support Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2019.04

Development

Successfully merging this pull request may close these issues.

5 participants

@jia200x @PeterKietzmann @aabadie @smlng @danpetry