Skip to content

gnrc_netif_ieee802154: propagate pend. frame flag to stack#11023

Merged
bergzand merged 1 commit intoRIOT-OS:masterfrom
miri64:gnrc_netif_ieee802154/enh/propagate-pend-frames
Mar 15, 2019
Merged

gnrc_netif_ieee802154: propagate pend. frame flag to stack#11023
bergzand merged 1 commit intoRIOT-OS:masterfrom
miri64:gnrc_netif_ieee802154/enh/propagate-pend-frames

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Feb 15, 2019

Contribution description

This way we can re-use the flag e.g. for forwarding.

Testing procedure

Sending broadcast 6LoWPAN packets should still work as before. Fragmented packets should have for the first n-1 fragments the GNRC_NETIF_HDR_FLAGS_MORE_DATA set. I checked the latter with the following patch:

diff --git a/sys/net/gnrc/netif/ieee802154/gnrc_netif_ieee802154.c b/sys/net/gnrc/netif/ieee802154/gnrc_netif_ieee802154.c
index 258237c58..01e758748 100644
--- a/sys/net/gnrc/netif/ieee802154/gnrc_netif_ieee802154.c
+++ b/sys/net/gnrc/netif/ieee802154/gnrc_netif_ieee802154.c
@@ -73,6 +73,7 @@ static gnrc_pktsnip_t *_make_netif_hdr(uint8_t *mhr)
     }
     /* set flags for pending frames */
     if (mhr[0] & IEEE802154_FCF_FRAME_PEND) {
+        puts("Set more data flag");
         hdr->flags |= GNRC_NETIF_HDR_FLAGS_MORE_DATA;
     }
     return snip;

Issues/PRs references

None

@miri64
gnrc_netif_ieee802154: propagate pend. frame flag to stack
eac066a 
This way we can re-use the flag e.g. for forwarding
@miri64 miri64 added the Area: network Area: Networking label Feb 15, 2019
@miri64 miri64 added this to the Release 2019.04 milestone Feb 15, 2019
@miri64 miri64 added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Feb 15, 2019
@miri64 miri64 mentioned this pull request Mar 12, 2019
Closed
@bergzand bergzand added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Mar 15, 2019
bergzand
bergzand approved these changes Mar 15, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using the suggested patch, works as advertised!

@bergzand bergzand added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 15, 2019
@bergzand bergzand merged commit ccc09d9 into RIOT-OS:master Mar 15, 2019
@miri64 miri64 deleted the gnrc_netif_ieee802154/enh/propagate-pend-frames branch March 28, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergzand bergzand bergzand approved these changes

@jnohlgard jnohlgard Awaiting requested review from jnohlgard

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

Assignees

No one assigned

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2019.04

Development

Successfully merging this pull request may close these issues.

2 participants

@miri64 @bergzand