Conversation
|
Nope, it's just a small fix and ready to merge as is, since it's mainly related to our SWP at the university. I can't see how #1039 is related (except that it also changes the make system ;-)), but I will do, if I find the time. |
|
OK. I'll give you an ACK if you give me an example how to use |
|
If you need specially build helper programs e.g. (CLEANFILES is in this case the counter part to ALLDEPS, since it removes what ALLDEPS builds). An example you can find in our starting dash port. |
|
Stop, I just found an error ;-) |
|
Now it is fixed ;-) |
|
The term "fixed" is relative, I guess. ;) |
|
OOps, now it should work. |
Makefile.include
Outdated
There was a problem hiding this comment.
Why so complicated?
@mkdir -p "$(dir $@)"
$(AD)$(CFLAGS) $(INCLUDES) -c "$<" -o "$@"But are you sure about the quotes? I thought (read: "it could be that") make would insert quotes automatically if need. Then your extra quotes would cancel these out.
There was a problem hiding this comment.
About the quotes I don't know
Why so complicated?
because technically they could be executed concurrently, if written like proposed.
There was a problem hiding this comment.
No, the lines in a target are sequentially. For every single command/line the return value is checked.
|
On a second though, isn't |
|
Yes you're right |
|
Looks good. ACK. |
|
NACK. #1098 (comment) was not addresse. |
|
Addressed and rebased |
There was a problem hiding this comment.
I'd use @ here, even with QUIET=0 we won't care about folder creation. Didn't know $(dir …), nice!
There was a problem hiding this comment.
I DO care, since they could appear in git's untracked files, and generally I like to no what happens in my filesystem ;-)
There was a problem hiding this comment.
Your filesystem belongs to RIOT, now!! 🔫
Explanation accepted, ACK.
There was a problem hiding this comment.
(I would even argue to remove the $(AD) completely ;-) edit: from this particular line)
There was a problem hiding this comment.
You can always have your own Makefile, just take care not to merge it. :P
|
ACK |
3 participants
This should make the Makefile.include more flexible for upcoming projects
make… ^^