Skip to content

cpu/fe310: Add call to periph_init()#10825

Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
maribu:fe310_periph_init
Feb 5, 2019
Merged

cpu/fe310: Add call to periph_init()#10825
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
maribu:fe310_periph_init

Conversation

@maribu
Copy link
Copy Markdown
Member

@maribu maribu commented Jan 19, 2019

Contribution description

Until now fe310's cpu_init() was missing a call to periph_init(). This commit adds this call.

Testing procedure

Check if the HiFive1 board still boots as expected

Issues/PRs references

Required for #10806

@maribu maribu added Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms Area: cpu Area: CPU/MCU ports labels Jan 19, 2019
@maribu
Copy link
Copy Markdown
Member Author

maribu commented Jan 19, 2019

@kenrabold: Would you mind to test his PR? If #10806 is rebased against this PR, #10806 should then also work (hopefully).

@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 19, 2019
@maribu
Copy link
Copy Markdown
Member Author

maribu commented Jan 19, 2019

I hope noone started to review now, so I'll just squash

@maribu maribu force-pushed the fe310_periph_init branch from dd890a6 to b8b7591 Compare January 19, 2019 11:59
@maribu
cpu/fe310: Add call to periph_init()
08fba76 
Until now fe310's cpu_init() was missing a call to periph_init().
This commit adds this call.
@maribu maribu force-pushed the fe310_periph_init branch from b8b7591 to 08fba76 Compare January 19, 2019 12:00
@maribu
Copy link
Copy Markdown
Member Author

maribu commented Jan 19, 2019

OK, now every issue uncovered by Murdock is solved. Sadly, I'm completely unable to tell if this PR actually works without having the hardware...

kenrabold
kenrabold approved these changes Jan 19, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@kenrabold kenrabold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this works on the HiFive1 board in conjunction with PR #10806

@maribu
Copy link
Copy Markdown
Member Author

maribu commented Jan 20, 2019

@kenrabold: Thanks for testing. Maybe @miri64 could also give this a quick look.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 20, 2019

I'm not really involved with the internals of the periph API. So rather someone else should have a look.

@miri64 miri64 added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Jan 20, 2019
@maribu
Copy link
Copy Markdown
Member Author

maribu commented Jan 20, 2019

If I read the git logs correctly, @haukepetersen has worked on both periph and the fe310 CPU. Maybe @haukepetersen could have a look?

@pyropeter pyropeter mentioned this pull request Jan 21, 2019
Closed
@maribu
Copy link
Copy Markdown
Member Author

maribu commented Jan 27, 2019

@haukepetersen: Mind to review? Only 5 lines changed ;-)

@maribu
Copy link
Copy Markdown
Member Author

maribu commented Feb 5, 2019

@jcarrano and @smlng seem to also have worked on cpu/fe310. Maybe one of you could review? @kenrabold thankfully already tested this PR.

kaspar030
kaspar030 approved these changes Feb 5, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaspar030 kaspar030 merged commit 5a35e6e into RIOT-OS:master Feb 5, 2019
@maribu maribu mentioned this pull request Feb 5, 2019
Closed
15 tasks
@maribu maribu deleted the fe310_periph_init branch March 8, 2019 16:42
@danpetry danpetry added this to the Release 2019.04 milestone Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

+1 more reviewer

@kenrabold kenrabold kenrabold approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2019.04

Development

Successfully merging this pull request may close these issues.

5 participants

@maribu @miri64 @kaspar030 @kenrabold @danpetry