cpu/esp*: compile time configurations for ESP MCUs#10766
Merged
gschorcht merged 2 commits intoRIOT-OS:masterfrom Jan 17, 2019
Merged
cpu/esp*: compile time configurations for ESP MCUs#10766gschorcht merged 2 commits intoRIOT-OS:masterfrom
gschorcht merged 2 commits intoRIOT-OS:masterfrom
Conversation
gschorcht
added
Type: enhancement
Member
|
great! Thank you! |
jia200x
added
the
CI: ready for build
Contributor
Author
|
@jia200x But it is not complete yet, just a beginning. |
Contributor
Author
|
@jia200x Is it possible to get this very small changes reviewed and mergeds? Thanks. |
MrKevinWeiss
approved these changes
Jan 17, 2019
Contributor
MrKevinWeiss
left a comment
MrKevinWeiss
left a comment
There was a problem hiding this comment.
Tested, looked at the code, and ACK!
Contributor
Author
|
@MrKevinWeiss Thank you for reviewing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds the groups for ESP MCUs to the
configgroup and adds first compile-time configuration macros to these groups.Testing procedure
Generate the documentation with
make docand checkModules / Compile time configurationspage for the modulesESP8266 compile configurationsandESP32 compile configurations.Issues/PRs references
This PR is prerequisite for PR #10762 and further upcoming PRs.