Skip to content

cpu: esp_common added for common modules of ESP SoCs#10663

Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom
gschorcht:cpu_esp_common
Dec 27, 2018
Merged

cpu: esp_common added for common modules of ESP SoCs#10663
miri64 merged 2 commits intoRIOT-OS:masterfrom
gschorcht:cpu_esp_common

Conversation

@gschorcht
Copy link
Copy Markdown
Contributor

@gschorcht gschorcht commented Dec 27, 2018 •
edited
Loading

Contribution description

This PR introduces cpu/esp_common for modules that are used by all ESP SoCs. As an example, the ESP-NOW netdev driver has been moved from cpu/esp32 to cpu/esp_common

Testing procedure

Compile examples/gnrc_networking with module esp_now for any ESP32 board, e.g.:

USEMODULE=esp_now make -C examples/gnrc_networking BOARD=esp32-wroom-32

Issues/PRs references

Required for refactoring of ESP implementation, issue #10658.
Required also for PR #10581 and #9917.

@gschorcht gschorcht added Area: build system Area: Build system Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Platform: ESP Platform: This PR/issue effects ESP-based platforms Area: cpu Area: CPU/MCU ports labels Dec 27, 2018
This was referenced Dec 27, 2018
Closed
Merged
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed Area: build system Area: Build system labels Dec 27, 2018
@miri64
Copy link
Copy Markdown
Member

miri64 commented Dec 27, 2018

Looks good to me, let's see how Murdock likes it.

miri64
miri64 approved these changes Dec 27, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK & go

@miri64 miri64 merged commit 7414ddb into RIOT-OS:master Dec 27, 2018
@miri64 miri64 mentioned this pull request Dec 27, 2018
Merged
@miri64
Copy link
Copy Markdown
Member

miri64 commented Dec 27, 2018

(BTW I removed the Area: build system label, because this PR is not really about the build system but just cleans-up some Area: cpu related stuff ;-))

@miri64 miri64 mentioned this pull request Dec 27, 2018
Merged
@gschorcht
Copy link
Copy Markdown
Contributor Author

gschorcht commented Dec 28, 2018

Thanks

@gschorcht
Copy link
Copy Markdown
Contributor Author

gschorcht commented Dec 28, 2018

BTW I removed the Area: build system label, because this PR is not really about the build system but just cleans-up some Area: cpu related stuff ;-)

Not almost clear, when to use what labels. I thought it is related to the build system of ESP MCUs.

@aabadie aabadie added this to the Release 2019.01 milestone Dec 28, 2018
@gschorcht gschorcht deleted the cpu_esp_common branch January 11, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

No one assigned

Labels

Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2019.01

Development

Successfully merging this pull request may close these issues.

3 participants

@gschorcht @miri64 @aabadie