lora: add lora and loramac config macros to config doc group#10623
Merged
miri64 merged 4 commits intoRIOT-OS:masterfrom Dec 18, 2018
Merged
lora: add lora and loramac config macros to config doc group#10623miri64 merged 4 commits intoRIOT-OS:masterfrom
miri64 merged 4 commits intoRIOT-OS:masterfrom
Conversation
jia200x
added
TF: Config
jia200x
changed the title
miri64
requested changes
Dec 18, 2018
miri64
reviewed
Dec 18, 2018
Member
miri64
left a comment
miri64
left a comment
There was a problem hiding this comment.
Except for the nitpicks below I'm fine with this PR. make doc produces the expected output. You may squash
Member
|
Please squash |
jia200x
force-pushed
the
pr/lora_conf
branch
from
2a99811 to
3e33214
Compare
Member
Author
|
squashed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
See #10566
I also moved some
@brieftags outside of the#ifndefblock for consistency, and fixed a minor issue with an extra<character in a doxygen tag.Testing procedure
Compile documentation. Two new group for the configuration macros of
net_loraandnet_loramacshould show up both in theconfiggroup doc as well in the doc of the respectivenet_loraandnet_loramac(sub-)modules changed here.Issues/PRs references
Addresses #10566 in part