jlink: get flash and debug files from cli#10528
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Dec 3, 2018
Merged
Conversation
Get BINFILE and ELFFILE from command line instead of environment variable. Rename 'HEXFILE' to 'BINFILE' in the script as the binary file is used. The documentation was already talking about 'BINFILE' but 'BINFILE' was never exported by the build system and it was using 'HEXFILE' in the implementation.
cladmi
added
Area: build system
Contributor
|
@cladmi, thanks for trying to cleanup this kind of things. The changes proposed this PR make sense but doesn't work in all cases: I tried to flash several applications with nRF52dk, most of them can be flashed except the ones that embed the Nordic Softdevice blob. |
Contributor
Author
|
@aabadie There should not be any issues with the way it was handled but I may be missing something. Could you print both output from |
Contributor
|
@cladmi, I compared with master (and the 3 previous release branches) and I get the same issue with Nordic softdevice. So that may be a problem on my side, or a more general issue. To answer your request:
|
Contributor
Author
|
The diff between both looks the same as my example without I think the I found another way of comparing with master by checking the content of |
Contributor
It was indeed this. Reinstalling jlink fixed the problem... And this PR works like a charm: I tried using |
Contributor
Author
|
Thanks for the review ! :) |
49 tasks
miri64
added
the
Type: cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Get BINFILE and ELFFILE from command line instead of environment variable.
Rename 'HEXFILE' to 'BINFILE' in the script as the binary file is used.
The documentation was already talking about 'BINFILE' but 'BINFILE'
was never exported by the build system and it was using 'HEXFILE' in the
implementation.
Testing procedure
I cannot test flashing as I do not have boards or a Jlink flasher.
A real verification would also be great.
A partial test is to compare the content of
burn.segthat should be the same:My test is to check the executed command:
The difference with master is the following, which has nothing related to the actual flashing command but show
binfiletaken from argument.Same check for
debug:And the output diff with master also has nothing related to the executed debug commands but show
elffiletaken from argument:Issues/PRs references
#8838