gnrc_netif_hdr: provide wrappers for gnrc_netif_ipv6_iid_from_addr() #10520
Merged
haukepetersen merged 1 commit intoRIOT-OS:masterfrom Dec 7, 2018
Merged
Conversation
miri64
added
Type: enhancement
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 29, 2018
miri64
added
the
State: waiting for other PR
miri64
force-pushed
the
gnrc_netif_hdr/enh/conv-iid-getter
branch
from
b2c170a to
6bc5d0e
Compare
Member
Author
|
Rebased to current master and #10513. |
miri64
changed the title
miri64
force-pushed
the
gnrc_netif_hdr/enh/conv-iid-getter
branch
from
6bc5d0e to
aafb936
Compare
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 30, 2018
TimoRoth
reviewed
Dec 5, 2018
TimoRoth
reviewed
Dec 5, 2018
TimoRoth
reviewed
Dec 5, 2018
miri64
force-pushed
the
gnrc_netif_hdr/enh/conv-iid-getter
branch
from
aafb936 to
f86ad9d
Compare
Member
Author
|
Rebased to current master and #10513. |
miri64
force-pushed
the
gnrc_netif_hdr/enh/conv-iid-getter
branch
from
c9c951f to
b2017f5
Compare
Member
Author
|
And again :-D |
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Dec 5, 2018
haukepetersen
requested changes
Dec 6, 2018
Contributor
haukepetersen
left a comment
haukepetersen
left a comment
There was a problem hiding this comment.
Just a minor style issue, else the changes look valid to me. Will test once its rebased.
miri64
force-pushed
the
gnrc_netif_hdr/enh/conv-iid-getter
branch
from
2872116 to
1a6d4fd
Compare
miri64
added
CI: ready for build
Member
Author
|
Rebased and squashed to current master. This PR no longer has any dependencies. |
miri64
force-pushed
the
gnrc_netif_hdr/enh/conv-iid-getter
branch
from
1a6d4fd to
d1e8f93
Compare
Member
Author
|
Somehow the |
miri64
force-pushed
the
gnrc_netif_hdr/enh/conv-iid-getter
branch
from
d1e8f93 to
77dd725
Compare
Member
Author
|
Amended doxygen error fix pointed out by Travis. |
miri64
removed
the
CI: ready for build
Member
Author
|
Needs #10565 to be buildable by Murdock :-/ |
Member
Author
|
Also provided the proposed change from #10565 (comment) as a fixup commit. |
miri64
added
the
CI: ready for build
haukepetersen
approved these changes
Dec 7, 2018
Contributor
haukepetersen
left a comment
haukepetersen
left a comment
There was a problem hiding this comment.
re-ACK, no unsused param warnings for my NimBLE-CCN-lite build anymore.
Contributor
|
please squash |
For convenience ;-).
miri64
force-pushed
the
gnrc_netif_hdr/enh/conv-iid-getter
branch
from
c5d7941 to
4d4e96f
Compare
Member
Author
|
Squashed |
Contributor
|
nice. Go Murdock! |
Contributor
|
all green -> go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
These will provide some convenience when reworking
gnrc_sixlowpan_iphcfor non-IEEE802.15.4 address compression.Testing procedure
If reviewer asks for it I will provide some unittests in
tests/gnrc_netifbut that it works when #10513 works should be clear from the code.Issues/PRs references
Depends on
#10513(merged)and its dependencies.