esp_now: use NETDEV_TYPE_ESP_NOW as device type#10509
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Nov 29, 2018
Merged
Conversation
miri64
added
Type: enhancement
6 tasks
gschorcht
approved these changes
Nov 29, 2018
Contributor
|
Tested it with two different ESP32 boards and |
Contributor
|
Thanks, I have to this also for PR #9917 |
Member
Author
|
Thanks you for the review :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This device should get its own device type similar to the
cc110xas it is its own protocol. UsingNETDEV_TYPE_RAWmight lead to problems in the long run if other devices use the same device type but have different addressing schemes.Testing procedure
Applications using IPv6 ESP-Now should still work as before (can't test since I don't have access to these kind of devices).
Issues/PRs references
None so far, but goes towards an effort to improve device-type-based address handling for
gnrc_netif.