gnrc_mac: fix header includes#10505
Merged
bergzand merged 1 commit intoRIOT-OS:masterfrom Nov 29, 2018
Merged
Conversation
miri64
added
Type: bug
miri64
force-pushed
the
gnrc_mac/fix/header-includes
branch
from
3f574c1 to
c05e97d
Compare
smlng
removed
the
CI: ready for build
bergzand
added
CI: ready for build
The inclusion of `net/gnrc.h` in `net/gnrc/mac/types.h` header makes it impossible to include the `net/gnrc/netif.h` header within `net/gnrc/netif/hdr.h`, due to `net/gnrc/mac/types.h` being included with `net/gnrc/netif/mac.h` (which is included in `net/gnrc/netif.h`)
miri64
force-pushed
the
gnrc_mac/fix/header-includes
branch
from
c05e97d to
9d6a32b
Compare
Member
Author
|
Fixed and squashed another unnecessary broad header inclusion in |
miri64
added
the
CI: ready for build
Member
Author
|
Ping @bergzand? |
Member
|
Sorry, give me a sec to verify again |
Member
Author
|
Thank you! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The inclusion of
net/gnrc.hinnet/gnrc/mac/types.hheader makes it impossible to include thenet/gnrc/netif.hheader withinnet/gnrc/netif/hdr.h(which we want to do in #10500), due tonet/gnrc/mac/types.hbeing included withnet/gnrc/netif/mac.h(which is included innet/gnrc/netif.h)Testing procedure
examples/gnrc_networking_macshould still be able to run with default configuration (GoMacH) and LWMAC configuration:RIOT/examples/gnrc_networking_mac/Makefile
Lines 38 to 41 in fdde802
tests/unittests(tests-gnrc_mac_internal) should still compilable and being able to run.Issues/PRs references
Preparation step for #10500