slipdev: provide stdio multiplexing over SLIP by miri64 · Pull Request #10480 · RIOT-OS/RIOT

miri64 · 2018-11-27T15:40:38Z

Contribution description

This introduces SLIPMUX like stdio multiplexing to slipdev. It can be used in conjunction with sliptty from #10477.

Testing procedure

Test border router application with USEMODULE += slipdev_stdio instead of stdio_ethos with both sliptty and tunslip. Both still should work. Also apply the testing procedures from #10477.

Also try to use tunslip with just slipdev (without slipdev_stdio). It should still work as well (just without stdio).

Issues/PRs references

Requires #10477 for interaction with Linux machine

jnohlgard · 2018-12-17T08:31:54Z

Tested gnrc_border_router together with #10477, and it seems to be working well. There is a problem when the Linux host has no global IPv6 address configured which messes up the return routing, see #10477 (comment)

miri64 · 2019-01-24T08:38:08Z

Rebased to current master.

miri64 · 2019-06-06T10:36:25Z

Rebased to current master.

stale · 2019-12-08T11:00:31Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

miri64 · 2020-02-25T09:35:38Z

Rebased to current master. I think it still needs adaptation for the current stdio model.

miri64 · 2020-02-25T09:57:11Z

Adapted to current master

benpicco · 2020-03-03T18:32:05Z

You can also remove examples/gcoap/slipdev_params.h and tests/slip/slipdev_params.h

examples/gnrc_border_router/Makefile.slip.conf

examples/gcoap/Makefile.slip

benpicco · 2020-03-05T21:51:05Z

With SLIP_BAUDRATE=2000000 stdin suffers

ifconfig
ifcfig
shell: command not found: ifcfig
> ifconfig
ifcfig
shell: command not found: ifcfig
> ifcoonnfig
ifcnnfig
shell: command not found: ifcnnfig
> ifcooonfig
ifconfig
Iface  7 
          MTU:65535  HL:64  RTR  
          RTR_ADV  
          Link type: wired
          inet6 addr: fe80::2  scope: link  VAL
          inet6 group: ff02::2
          inet6 group: ff02::1
          inet6 group: ff02::1:ff00:2
          
Iface  6  HWaddr: 71:A1  Channel: 26  Page: 0  NID: 0x23
          Long HWaddr: 5A:06:59:C9:2C:36:7D:78 
           TX-Power: 0dBm  State: IDLE  max. Retrans.: 3  CSMA Retries: 4 
          AUTOACK  ACK_REQ  CSMA  L2-PDU:102 MTU:1280  HL:64  RTR  
          RTR_ADV  6LO  IPHC  
          Source address length: 8
          Link type: wireless
          inet6 addr: fe80::5806:59c9:2c36:7d78  scope: link  VAL
          inet6 addr: 2001:db8::5806:59c9:2c36:7d78  scope: global  VAL
          inet6 group: ff02::2
          inet6 group: ff02::1
          inet6 group: ff02::1:ff36:7d78

but IP operation (e.g. ping -f) remains stable.

miri64 · 2020-03-05T22:14:59Z

The input fd is handled last by the sliptty tool. That might be the reason for the priorisation.

miri64 · 2020-03-05T22:25:24Z

Note to self fd6c880 is titled wrong.

miri64 · 2020-03-05T22:34:31Z

The input fd is handled last by the sliptty tool. That might be the reason for the priorisation.

Oh wait, did you mean there is loss without any load?

miri64 · 2020-03-05T22:35:05Z

If yes, does the same happen for stdio_uart?

miri64 · 2020-03-05T22:37:26Z

Interesting observation (not sure it has anything to do with this): all letters of ifconfig start with a 0x6 nibble (the signifyer for an IPv6 packet):

In [5]: [hex(ord(a)) for a in "ifconfig"]                                                                                                                                                                                             
Out[5]: ['0x69', '0x66', '0x63', '0x6f', '0x6e', '0x66', '0x69', '0x67']

benpicco · 2020-03-05T23:01:15Z

If yes, does the same happen for stdio_uart?

Yes, also happens in gnrc_networking with CFLAGS += -DSTDIO_UART_BAUDRATE=2000000, so this is unrelated.

benpicco · 2020-03-05T23:01:38Z

Please squash!

miri64 · 2020-03-06T07:28:04Z

Squashed

miri64 · 2020-03-06T07:58:10Z

Fixed travis errors and squashed.

It's not needed anymore.

miri64 · 2020-03-06T08:00:08Z

And fixed compile time errors.

miri64 · 2020-03-06T11:16:28Z

(maybe we should add the same hack we use for start_network.sh for SLIP as we have for ethos, to add a global address to the loopback interface sweat_smile)

See #13572.

miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking Area: drivers Area: Device drivers labels Nov 27, 2018

miri64 requested review from jnohlgard and kaspar030 November 27, 2018 15:40

miri64 mentioned this pull request Nov 27, 2018

gnrc_ipv6_nib: don't autoconfig IPv6 address without L2 addr #10483

Merged

miri64 force-pushed the slipdev/feat/stdio branch from 2b4e555 to 2b88795 Compare November 28, 2018 07:24

RIOT-OS deleted a comment Nov 28, 2018

miri64 mentioned this pull request Dec 18, 2018

ethos: Add OS X compatibility #6718

Closed

miri64 mentioned this pull request Jan 18, 2019

gnrc_netif: check all required options on initialization #10532

Merged

7 tasks

miri64 force-pushed the slipdev/feat/stdio branch from 9a496c4 to 35cd1d7 Compare January 24, 2019 08:38

miri64 mentioned this pull request Apr 2, 2019

sliptty: introduce a new SLIP to TUN tool #10477

Merged

miri64 mentioned this pull request Apr 9, 2019

tools/tunslip: correct typos and refine readme #11363

Merged

danpetry mentioned this pull request Apr 23, 2019

gnrc_ipv6_nib: don't autoconfig IPv6 address without L2 addr [backport 2019.04] #11430

Merged

miri64 force-pushed the slipdev/feat/stdio branch from 35cd1d7 to 9681125 Compare June 6, 2019 10:36

miri64 mentioned this pull request Sep 25, 2019

ethos: fails to respond to first message. #11988

Open

stale bot added the State: stale State: The issue / PR has no activity for >185 days label Dec 8, 2019

miri64 removed the State: stale State: The issue / PR has no activity for >185 days label Dec 8, 2019

miri64 force-pushed the slipdev/feat/stdio branch from 9681125 to 6bf68dd Compare February 25, 2020 09:35

miri64 requested review from aabadie and fjmolinas as code owners February 25, 2020 09:35

miri64 mentioned this pull request Feb 25, 2020

stdio: a layered / multiheaded approach to I/O #13469

Closed

miri64 mentioned this pull request Mar 3, 2020

drivers/slip: move slipdev_params.h to drivers folder #13544

Closed

benpicco reviewed Mar 5, 2020

View reviewed changes

examples/gnrc_border_router/Makefile.slip.conf Outdated Show resolved Hide resolved

benpicco reviewed Mar 5, 2020

View reviewed changes

examples/gcoap/Makefile.slip Outdated Show resolved Hide resolved

benpicco reviewed Mar 5, 2020

View reviewed changes

examples/gcoap/Makefile.slip Outdated Show resolved Hide resolved

benpicco approved these changes Mar 5, 2020

View reviewed changes

benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 5, 2020

miri64 force-pushed the slipdev/feat/stdio branch from 950a1d9 to 29d2bee Compare March 6, 2020 07:28

slipdev: expose marker byte definitions

79e80d4

miri64 force-pushed the slipdev/feat/stdio branch from 29d2bee to 5cc1219 Compare March 6, 2020 07:57

miri64 and others added 5 commits March 6, 2020 08:58

slipdev: internally expose byte stuffing functionality

f119409

slipmux: remove inesc member

8e82705

It's not needed anymore.

slipdev_stdio: provide stdio multiplexing over SLIP

ff42557

examples: adapt border router example for slipdev_stdio

f847cde

examples: remove unnecessary slipdev_params.h

3db895a

miri64 force-pushed the slipdev/feat/stdio branch from 5cc1219 to 3db895a Compare March 6, 2020 08:00

miri64 merged commit 16937d0 into RIOT-OS:master Mar 6, 2020

miri64 deleted the slipdev/feat/stdio branch March 6, 2020 08:30

miri64 mentioned this pull request Mar 6, 2020

sliptty/start_network.sh: configure global address for SLIP interface #13572

Merged

leandrolanzieri added this to the Release 2020.04 milestone Mar 13, 2020

Conversation

miri64 commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution description

Testing procedure

Issues/PRs references

Uh oh!

jnohlgard commented Dec 17, 2018

Uh oh!

miri64 commented Jan 24, 2019

Uh oh!

miri64 commented Jun 6, 2019

Uh oh!

stale bot commented Dec 8, 2019

Uh oh!

miri64 commented Feb 25, 2020

Uh oh!

miri64 commented Feb 25, 2020

Uh oh!

benpicco commented Mar 3, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benpicco commented Mar 5, 2020

Uh oh!

miri64 commented Mar 5, 2020

Uh oh!

miri64 commented Mar 5, 2020

Uh oh!

miri64 commented Mar 5, 2020

Uh oh!

miri64 commented Mar 5, 2020

Uh oh!

miri64 commented Mar 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benpicco commented Mar 5, 2020

Uh oh!

benpicco commented Mar 5, 2020

Uh oh!

miri64 commented Mar 6, 2020

Uh oh!

miri64 commented Mar 6, 2020

Uh oh!

miri64 commented Mar 6, 2020

Uh oh!

miri64 commented Mar 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

miri64 commented Nov 27, 2018 •

edited

Loading

miri64 commented Mar 5, 2020 •

edited

Loading