Skip to content

opencm904/flash: get arguments from cli#10474

Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/make/opencm904/flashfile_from_cli
Nov 27, 2018
Merged

opencm904/flash: get arguments from cli#10474
aabadie merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/make/opencm904/flashfile_from_cli

Conversation

@cladmi
Copy link
Copy Markdown
Contributor

@cladmi cladmi commented Nov 26, 2018

Contribution description

Prepares from having FLASHFILE variable.

Testing procedure

Try flashing for the board:

BOARD=opencm904 make --no-print-directory -C examples/hello-world/ flash
Building application "hello-world" for "opencm904" with MCU "stm32f1".

"make" -C /home/harter/work/git/RIOT/boards/opencm904
"make" -C /home/harter/work/git/RIOT/core
"make" -C /home/harter/work/git/RIOT/cpu/stm32f1
"make" -C /home/harter/work/git/RIOT/cpu/cortexm_common
"make" -C /home/harter/work/git/RIOT/cpu/cortexm_common/periph
"make" -C /home/harter/work/git/RIOT/cpu/stm32_common
"make" -C /home/harter/work/git/RIOT/cpu/stm32_common/periph
"make" -C /home/harter/work/git/RIOT/cpu/stm32f1/periph
"make" -C /home/harter/work/git/RIOT/drivers
"make" -C /home/harter/work/git/RIOT/drivers/periph_common
"make" -C /home/harter/work/git/RIOT/sys
"make" -C /home/harter/work/git/RIOT/sys/auto_init
"make" -C /home/harter/work/git/RIOT/sys/isrpipe
"make" -C /home/harter/work/git/RIOT/sys/newlib_syscalls_default
"make" -C /home/harter/work/git/RIOT/sys/pm_layered
"make" -C /home/harter/work/git/RIOT/sys/stdio_uart
"make" -C /home/harter/work/git/RIOT/sys/tsrb
   text    data     bss     dec     hex filename
   8412     140    2620   11172    2ba4 /home/harter/work/git/RIOT/examples/hello-world/bin/opencm904/hello-world.elf
/home/harter/work/git/RIOT/boards/opencm904/dist/robotis-loader.py /dev/ttyACM0 /home/harter/work/git/RIOT/examples/hello-world/bin/opencm904/hello-world.bin
~~ Robotis loader ~~

Please, make sure to connect the USB cable WHILE holding down the "USER SW" button.
Status LED should stay lit and the board should be able to load the program.

* Opening /home/harter/work/git/RIOT/examples/hello-world/bin/opencm904/hello-world.bin, size=8552
* Resetting the board
* Connecting...
* Download signal transmitted, waiting...
# Not actually flashing as I do not have the board

You can see that the binfile is correctly read, you can also print port to compare the value.

And it should have the same behavior has in master.

The changes were already tested by @astralien3000 in #8838 (comment)

Issues/PRs references

Split from #8838

@cladmi cladmi added Area: build system Area: Build system Area: tools Area: Supplementary tools Area: boards Area: Board ports labels Nov 26, 2018
@cladmi cladmi mentioned this pull request Nov 26, 2018
Merged
49 tasks
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 27, 2018
aabadie
aabadie approved these changes Nov 27, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, changes are the same as the ones from the original PR #8838.

The changes are good and were tested with success by @astralien3000.

ACK

@aabadie aabadie merged commit ad5d4ff into RIOT-OS:master Nov 27, 2018
@cladmi cladmi deleted the pr/make/opencm904/flashfile_from_cli branch November 27, 2018 11:28
@cladmi
Copy link
Copy Markdown
Contributor Author

cladmi commented Nov 27, 2018

Thanks for the review

@aabadie aabadie added this to the Release 2019.01 milestone Dec 2, 2018
@miri64 miri64 added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabadie aabadie aabadie approved these changes

Assignees

No one assigned

Labels

Area: boards Area: Board ports Area: build system Area: Build system Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2019.01

Development

Successfully merging this pull request may close these issues.

3 participants

@cladmi @aabadie @miri64