board/*/flash.sh: get file to flash from command line#10473
Merged
aabadie merged 3 commits intoRIOT-OS:masterfrom Dec 3, 2018
Merged
board/*/flash.sh: get file to flash from command line#10473aabadie merged 3 commits intoRIOT-OS:masterfrom
aabadie merged 3 commits intoRIOT-OS:masterfrom
Conversation
cladmi
added
Area: build system
49 tasks
aabadie
approved these changes
Dec 3, 2018
Contributor
aabadie
left a comment
aabadie
left a comment
There was a problem hiding this comment.
Code changes are good.
I tested with microbit and mbed_lpc1768. I don't have a calliope-mini but I trust your test here.
ACK and go
aabadie
added
the
CI: ready for build
Contributor
|
Let's wait for Murdock before merging |
Contributor
Author
|
Thank you for the review ! 👍 |
miri64
added
the
Type: cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
For the
flash.shflasher, get the file to flash from command line instead of environment variableThis is a prepare step to move to having a
FLASHFILEvariable.Testing procedure
Flash with the given boards as it is hard to test only the output.
Or review the changes and check to put debug in the flash scripts.
I self tested
calliope-miniandmbed_lpc1768in #8838 (comment) but it is not an external test.Issues/PRs references
Split from #8838